Opened 5 years ago

Closed 5 years ago

#9803 closed Bug report (fixed)

Unable to Download/Delete Via Remote File Search

Reported by: Trevor Owned by:
Priority: normal Component: FileZilla Client
Keywords: download delete remote search Cc: brunoramos.lu@…
Component version: Operating system type: OS X
Operating system version: Mac OS X 10.10 DP 6

Description

Upon connecting to a remote server, clicking the binocular icon to use remote file search, and then performing a search, attempting to right click a file or folder and then selecting download will not perform the action. The file/folder will not be added to the download queue. If "Delete" is selected instead of "Download", that file/folder will also not be deleted.

FileZilla Client


Version: 3.9.0.3

Build information:

Compiled for: x86_64-apple-darwin13.3.0
Compiled on: x86_64-apple-darwin13.3.0
Build date: 2014-08-13
Compiled with: Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
Compiler flags: -g -O2 -Wall -g -fexceptions -std=gnu++11

Linked against:

wxWidgets: 3.0.2
GnuTLS: 3.2.15
SQLite: 3.8.5

Operating system:

Name: Mac OS X (Darwin 14.0.0 x86_64)
Version: 10.10

Change History (4)

comment:1 Changed 5 years ago by Trevor

Keywords: delete remote search added

comment:2 Changed 5 years ago by Bruno Ramos

Cc: brunoramos.lu@… added

Confirmed also on Debian GNU/Linux - FileZilla 3.9.0.1

I'm not familiar with the code, but I was to confirm that the problem comes from the if statement highlighted below.
Commenting the event.Skip() and return statements brings the popup menu back.

From src/interface/search.cpp:

void CSearchDialog::OnContextMenu(wxContextMenuEvent& event)
{

if (event.GetEventObject() != m_results)
{

event.Skip();
return;

}

...

comment:3 Changed 5 years ago by Bruno Ramos

Additional details.

Problem happens when you right-click on one of the entries in the list containing the results.
Clicking the empty space (outside the lines in the results) will work and display the popup menu.

Steps to Reproduce:

  1. Start Filezilla
  2. Connect to an FTP server
  3. Press F3 to start a remote search
  4. Enter a filter that will return some matches (I have one in my case)
  5. Press "Search"
  6. Right-click the entry in the list (no popup menu will show, the entry is just selected by this action)

Important: With the entry selected right-click on the empty area right below the result present in the list and this time the popup menu will show.

comment:4 Changed 5 years ago by Tim Kosse

Resolution: fixed
Status: newclosed

This is a platform specific bug happening on platforms using wx' generic list control.

Event object for this specific event is the contained child window, not the list control itself.

A fix has been committed to the repository that solves this issue in revision 6049.

Note: See TracTickets for help on using tickets.