Cleanup of the Windows Start Menu entries for the client

[RedBlackAka]

Hi!
I would like to present a small change regarding the Windows Start Menu shortcut in NSIS:

File: FileZilla3/trunk/data/install.nsi.in

snippet:

; Create shortcuts

1204   SetOutPath "$INSTDIR"
1205   CreateDirectory "$SMPROGRAMS\$STARTMENU_FOLDER"
1206   CreateShortCut "$SMPROGRAMS\$STARTMENU_FOLDER\Uninstall.lnk" "$INSTDIR\Uninstall.exe"
1207   CreateShortCut "$SMPROGRAMS\$STARTMENU_FOLDER\FileZilla.lnk" "$INSTDIR\filezilla.exe"

${If} ${AtLeastWin7}

1210   ; Setting AppID
1211   push "FileZilla.Client.AppID"
1212   push "$SMPROGRAMS\$STARTMENU_FOLDER\FileZilla.lnk"
1213   nsis_appid::set_appid
1214   ${EndIf}

1501   Delete "$SMPROGRAMS\$MUI_TEMP\Uninstall.lnk"
1502   Delete "$SMPROGRAMS\$MUI_TEMP\FileZilla.lnk"

Change to:

; Create shortcuts

1204   SetOutPath "$INSTDIR"
1205   CreateShortCut "$SMPROGRAMS\FileZilla.lnk" "$INSTDIR\filezilla.exe"

${If} ${AtLeastWin7}

1208   ; Setting AppID
1209   push "FileZilla.Client.AppID"
1210   push "$SMPROGRAMS\FileZilla.lnk"
1211   nsis_appid::set_appid
1213   ${EndIf}

1499   Delete "$SMPROGRAMS\$MUI_TEMP\Uninstall.lnk"
1500   Delete "$SMPROGRAMS\$MUI_TEMP\FileZilla.lnk"
1501   Delete "$SMPROGRAMS\FileZilla.lnk"

Plus everything that mentions $STARTMENU_FOLDER seems to become obsolete and can be removed.

Explanation:
Since at least Windows 10, uninstall .lnks are not created and there always ends up being only one entry in the Start Menu folder. Since it just a file, it is unclean to have an entire folder for it in the Start Menu and it requires an extra click to expand. Therefore this change simplifies it, making the entry appear cleaner and following more modern conventions.
Note: Windows 11 actually hides the folder if there is only one content, but it is still good to get rid of it (especially for those W10 users like me).