Ability to rename tabs

[Ruben Benjamin]

When we have multiple tabs open for an FTP site all the tabs have the same name. User has to click on each tab to look for the folder that he needs. It would be great if we could right click on a tab and rename it as we like

[harsh]

void CContextControl::OnTabContextRename(wxCommandEvent& event)
{

CInputDialog dlg;
if (!dlg.Create(this, _("Rename Tab"), _("Please enter new name for the tab:")))

return;

if (dlg.ShowModal() != wxID_OK)

return;

for (size_t j = 0; j < m_context_controls.size(); j++) {

if (m_context_controls[j].tab_index != m_right_clicked_tab)

continue;

m_context_controls[j].pState->SetTitle(dlg.GetValue());

CContextControl::_context_controls* controls = GetControlsFromState(m_context_controls[j].pState);
m_tabs->SetPageText(controls->tab_index, controls->pState->GetTitle());

break;

}

}

This is part of the patch.

[harsh]

please ignore the above two attachments. I will upload the proper patch file soon

[fatabbot]

What's the status on this?

Can't seem to find an option for this. It would be so convenient to have this, as I often have 3-4 tabs open for the same site, which display all with the same tab name.

[JWWalker]

This would really be helpful.

[Daniel Beardsmore]

If it were me, I would:

Add CInputDialog::SetValue(wxString const& value, bool selectAll), that uses this->SetValue(wxString const& value) to set the text, then takes the string length to call this->SelectText(0, length_of_new_text) so that it’s selected, so that the user can easy overtype the existing text, or amend it (pretend that is valid C++ ;-)

1. When asked to rename the tab, first get the tab, and then read off its current name (move the code to find the tab, to the start)
2. Create the dialog
3. Call the new SelectText to put the existing text into the dialog and select it
4. Set the new tab text, unless Cancel was hit

This allows you to adjust tab names, as well as be sure that you are in fact renaming the correct tab!

(I thought that FileZilla could rename tabs, but apparently not … I must be thinking of some other program where that is possible.)