Opened 8 years ago

Closed 7 years ago

#7991 closed Patch (rejected)

Local file select tool

Reported by: aug125 Owned by:
Priority: normal Component: FileZilla Client
Keywords: Cc: plichonaugustin@…
Component version: Operating system type: Linux
Operating system version: Linux Ubuntu 11.04

Description

Hello,

I developed a tool to select the local files of listview based on criteria (size, name, date). It is not recursive. Furthermore, no translation was provided.

Regards.

Attachments (8)

myModif.patch (8.6 KB) - added by aug125 8 years ago.
myModif.2.patch (8.6 KB) - added by aug125 8 years ago.
myModif.3.patch (8.6 KB) - added by aug125 8 years ago.
myModif.4.patch (8.6 KB) - added by aug125 8 years ago.
myModif.5.patch (8.6 KB) - added by aug125 8 years ago.
myModif.6.patch (14.9 KB) - added by aug125 8 years ago.
myModif.7.patch (14.9 KB) - added by aug125 8 years ago.
myModif.8.patch (14.9 KB) - added by aug125 8 years ago.

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by aug125

Attachment: myModif.patch added

Changed 8 years ago by aug125

Attachment: myModif.2.patch added

Changed 8 years ago by aug125

Attachment: myModif.3.patch added

comment:1 Changed 8 years ago by aug125

Please take only myModif.3.patch.

Changed 8 years ago by aug125

Attachment: myModif.4.patch added

comment:2 in reply to:  1 Changed 8 years ago by aug125

Please take only myModif.4.patch.

Changed 8 years ago by aug125

Attachment: myModif.5.patch added

Changed 8 years ago by aug125

Attachment: myModif.6.patch added

comment:3 Changed 8 years ago by aug125

Please take only myModif.6.patch.

Changed 8 years ago by aug125

Attachment: myModif.7.patch added

Changed 8 years ago by aug125

Attachment: myModif.8.patch added

comment:4 Changed 8 years ago by aug125

Please take myModif.8.patch.

comment:5 Changed 7 years ago by Tim Kosse

Resolution: rejected
Status: newclosed

Unfortunately this patch isn't acceptable:

  • Not using the correct unit conversions, e.g. if Base-2 IEC prefixes have been selected in the settings dialog (the default)
  • Not providing translations is fine, but not marking all strings to be translatable is not
  • Splitting "Larger" and "than" into two controls isn't translatable. In other languages the order is the other way around or there's no need for "than"
  • There's already a search dialog in FileZilla for remote file, why not extend it to also search local files?
Note: See TracTickets for help on using tickets.