Opened 13 years ago
Closed 12 years ago
#7831 closed Patch (rejected)
Strip VMS revisions option doesn't work. Here is a fix
Reported by: | henri | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | FileZilla Client |
Keywords: | vms | Cc: | william.bell@… |
Component version: | Operating system type: | Windows | |
Operating system version: | windows 7 |
Description
Hi,
The Strip VMS revisions doesn't seem to work on OpenVms servers. It's used at some places in the code, but it's missing in the ParseAsVms() method. I propose this fix that will, in this method only, check if the option is enabled and if we are dealing with a file. If so, we strip the version number from the file.
The result is that the folder listing is now more containing the version numbers, and downloading a file will now get the correct filename, stripped of it's version number (which is useless on windows/unix systems).
Also, the downloaded file is the most recent one (the most updated version from the server).
Attachments (2)
Change History (5)
by , 13 years ago
Attachment: | directorylistingparser.cpp added |
---|
comment:1 by , 13 years ago
In this method :
bool CDirectoryListingParser::ParseAsVms(CLine *pLine, CDirentry &entry)
You'll find this new code if you diff this file with the current SVN one:
else files
{
if (COptions::Get()->GetOptionVal(OPTION_STRIP_VMS_REVISION))
entry.name = StripVMSRevision(token.GetString());
else
entry.name = token.GetString();
}
by , 13 years ago
Attachment: | Ticket7831.patch added |
---|
comment:2 by , 13 years ago
Cc: | added |
---|
comment:3 by , 12 years ago
Resolution: | → rejected |
---|---|
Status: | new → closed |
This doesn't seem right, in particular you can no longer see multiple revisions with your patch, only multiple times the stripped one.
Also, including something from the interface in the engine is a technical no-go as that introduces a cyclic dependency making it impossible to compile FileZilla.
ParseAsVms method fixed to support Vms filenames