Opened 8 years ago

Closed 7 years ago

#7831 closed Patch (rejected)

Strip VMS revisions option doesn't work. Here is a fix

Reported by: henri Owned by:
Priority: normal Component: FileZilla Client
Keywords: vms Cc: william.bell@…
Component version: Operating system type: Windows
Operating system version: windows 7

Description

Hi,
The Strip VMS revisions doesn't seem to work on OpenVms servers. It's used at some places in the code, but it's missing in the ParseAsVms() method. I propose this fix that will, in this method only, check if the option is enabled and if we are dealing with a file. If so, we strip the version number from the file.

The result is that the folder listing is now more containing the version numbers, and downloading a file will now get the correct filename, stripped of it's version number (which is useless on windows/unix systems).

Also, the downloaded file is the most recent one (the most updated version from the server).

Attachments (2)

directorylistingparser.cpp (65.0 KB) - added by henri 8 years ago.
ParseAsVms method fixed to support Vms filenames
Ticket7831.patch (913 bytes) - added by henri 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by henri

Attachment: directorylistingparser.cpp added

ParseAsVms method fixed to support Vms filenames

comment:1 Changed 8 years ago by henri

In this method :
bool CDirectoryListingParser::ParseAsVms(CLine *pLine, CDirentry &entry)

You'll find this new code if you diff this file with the current SVN one:

else files
{

if (COptions::Get()->GetOptionVal(OPTION_STRIP_VMS_REVISION))

entry.name = StripVMSRevision(token.GetString());

else

entry.name = token.GetString();

}

Changed 8 years ago by henri

Attachment: Ticket7831.patch added

comment:2 Changed 7 years ago by William Bell

Cc: william.bell@… added

comment:3 Changed 7 years ago by Tim Kosse

Resolution: rejected
Status: newclosed

This doesn't seem right, in particular you can no longer see multiple revisions with your patch, only multiple times the stripped one.

Also, including something from the interface in the engine is a technical no-go as that introduces a cyclic dependency making it impossible to compile FileZilla.

Note: See TracTickets for help on using tickets.