Opened 14 years ago
Closed 10 years ago
#7247 closed Bug report (fixed)
Speed limit icon isn't updated when changing themes
| Reported by: | starnixsa | Owned by: | Tim Kosse |
|---|---|---|---|
| Priority: | low | Component: | FileZilla Client |
| Keywords: | Cc: | ||
| Component version: | Operating system type: | Linux | |
| Operating system version: | Ubuntu 10.10 |
Description
After changing the interface theme in settings, the icon bar icons are updated but not the icon for the speed limits. (see bug #5504, but for linux this time round)
Attachments (1)
Change History (5)
comment:1 by , 14 years ago
| Priority: | normal → low |
|---|
comment:2 by , 10 years ago
by , 10 years ago
| Attachment: | update-statusbar-when-theme-changes.patch added |
|---|
[Patch] update status bar when theme changes
comment:3 by , 10 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
Small patch to fix this problem.
I was unable to update the icon in the existing status bar.
So I used the same solution as for some of the other components, delete the old status bar and put a new one in place.
Tested under Debian GNU/Linux only for the moment.
comment:4 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Patch rejected, it does not fix the underlying cause. The status bar itself is already reloading the icon if the theme option changes (see CStatusBar::OnOptionChanged)
The root cause is that the various option change handlers are getting notified in an undefined order. The solution is to preserve the relative order of the option change event handlers.
A fix for the latter has been committed to the repository.
Confirmed.
This is happening again, tested on both windows and Linux with the latest version.
When changing the icon theme most icons are updated but not the one on the status bar for speed limits.