Opened 10 years ago

Closed 10 years ago

#5277 closed Bug report (fixed)

CPermissions Init Err

Reported by: WangGuangbin Owned by:
Priority: high Component: FileZilla Server
Keywords: PermissionsHelperWindow Cc: guangbinw#gmail
Component version: Operating system type: Windows
Operating system version: every version

Description

CPermissions has a member m_pPermissionsHelperWindow.The window is initilized After an CPermissions instance was added to the m_sInstanceList.
In some critical case,another CPermissions instance may call the CPermissions::UpdateInstances().In this Func,the uninitlized window is used.Mem Crash!

ASSERT((*iter)->m_pPermissionsHelperWindow); m_pPermissionsHelperWindow is not initlized,so it might be any value
::PostMessage((*iter)->m_pPermissionsHelperWindow->GetHwnd(), WM_USER, 0, 0);

In my pc,Init helper window before add to list is ok.

Change History (3)

comment:1 Changed 10 years ago by WangGuangbin

Cc: guangbinw@… added

comment:2 Changed 10 years ago by WangGuangbin

Cc: guangbinw@… removed

comment:3 Changed 10 years ago by Tim Kosse

Priority: criticalhigh
Resolution: fixed
Status: newclosed

Thank you very much for spotting this issue.

The solution is to create the window first thing after obtaining the critical section in CPermissions::Init

A fix has been committed to the repository.

(Ticket priority decreased to High as it is not a remotely exploitable security vulnerability)

Note: See TracTickets for help on using tickets.