Opened 10 years ago

Closed 10 years ago

#5019 closed Patch (fixed)

Fix precompiled header support for TinyXml

Reported by: eyebex Owned by:
Priority: normal Component: FileZilla Server
Keywords: TinyXml, PCH Cc:
Component version: Operating system type: Windows
Operating system version:

Description

The committed TinyXml files miss to include stdafx.h as the first file for precompiled header support, which results in a compile error. The attached patch fixes this.

Attachments (2)

TinyXmlPreComp.patch (1.1 KB) - added by eyebex 10 years ago.
DisablePCHForTinyXml.patch (2.6 KB) - added by eyebex 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by eyebex

Attachment: TinyXmlPreComp.patch added

comment:1 Changed 10 years ago by Tim Kosse

Resolution: rejected
Status: newclosed

Thanks, however it is better to not modify third-party files if it can be avoided.

The Visual Studio project workspace files in the repository already disable the use of precompiled headers for the tinyxml sources.

comment:2 Changed 10 years ago by eyebex

Resolution: rejected
Status: closedreopened

It seem you only did this for the "Release" target, which is why I ran into the compile error in the first place for the "Debug" target. The attached new patch also disables the use of precompiled headers for the TinyXml sources for the "Debug" and "Memcheck" targets.

Changed 10 years ago by eyebex

Attachment: DisablePCHForTinyXml.patch added

comment:3 Changed 10 years ago by Tim Kosse

Resolution: fixed
Status: reopenedclosed

Thanks, applied.

Note: See TracTickets for help on using tickets.