Opened 15 years ago
Closed 15 years ago
#5019 closed Patch (fixed)
Fix precompiled header support for TinyXml
| Reported by: | eyebex | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | FileZilla Server |
| Keywords: | TinyXml, PCH | Cc: | |
| Component version: | Operating system type: | Windows | |
| Operating system version: |
Description
The committed TinyXml files miss to include stdafx.h as the first file for precompiled header support, which results in a compile error. The attached patch fixes this.
Attachments (2)
Change History (5)
by , 15 years ago
| Attachment: | TinyXmlPreComp.patch added |
|---|
comment:1 by , 15 years ago
| Resolution: | → rejected |
|---|---|
| Status: | new → closed |
comment:2 by , 15 years ago
| Resolution: | rejected |
|---|---|
| Status: | closed → reopened |
It seem you only did this for the "Release" target, which is why I ran into the compile error in the first place for the "Debug" target. The attached new patch also disables the use of precompiled headers for the TinyXml sources for the "Debug" and "Memcheck" targets.
by , 15 years ago
| Attachment: | DisablePCHForTinyXml.patch added |
|---|
Note:
See TracTickets
for help on using tickets.
Thanks, however it is better to not modify third-party files if it can be avoided.
The Visual Studio project workspace files in the repository already disable the use of precompiled headers for the tinyxml sources.