Opened 11 years ago

Closed 10 years ago

#4265 closed Patch (fixed)

Make big digits format more user friendly.

Reported by: silamantex Owned by:
Priority: normal Component: FileZilla Server
Keywords: output format user friendly big digits gui Cc: silamantex@…
Component version: Operating system type: Windows
Operating system version:

Description

Hi,

It is difficult to read some values in FileZilla Server interface. Such received/sent bytes number etc.

I would like to propouse patch. It divide big numbers by groups, with three digits per each. It is much more easy to read.

Thanks!

Attachments (3)

make numbers user friendly.zip (82.5 KB) - added by silamantex 11 years ago.
patch, sources and example
difference.png (82.7 KB) - added by silamantex 11 years ago.
Example of result
OutputFormat.cpp (764 bytes) - added by silamantex 11 years ago.
updated version 2009.03.05

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by silamantex

patch, sources and example

Changed 11 years ago by silamantex

Attachment: difference.png added

Example of result

comment:1 Changed 11 years ago by Tim Kosse

Status: newmoreinfo

Thanks, some remarks:

  • cstringt.h, is that filea vailable on older versions of visual studio? (especially 2003)
  • in Unicode build it'll either fail to compile or there will be lots of additional conversions. Use _T()
  • Use GetLocaleInfo to get the proper separator character/string for number formatting. For example English locale uses comma and German locale uses dot, not spaces.

Changed 11 years ago by silamantex

Attachment: OutputFormat.cpp added

updated version 2009.03.05

comment:2 Changed 11 years ago by silamantex

Cc: silamantex@… added
Status: moreinfonew

I have no ability to check cstringt.h under VS2003. But I find in Internet that file should exist there.

Unicode and GetLocaleInfo() added. New version of .cpp attached.

comment:3 Changed 11 years ago by silamantex

Actually it is possible to remove "#include <cstringt.h>" from header OutputFormat.h . Because CString definition available through
<stdafx.h> -> <afxwin.h>

comment:4 Changed 10 years ago by Tim Kosse

Resolution: fixed
Status: newclosed

Thanks for the patch.

I've slightly adjusted it to get rid of expensive MakeReverse.

Note: See TracTickets for help on using tickets.