Opened 15 years ago

Closed 15 years ago

#4265 closed Patch (fixed)

Make big digits format more user friendly.

Reported by: silamantex Owned by:
Priority: normal Component: FileZilla Server
Keywords: output format user friendly big digits gui Cc: silamantex@…
Component version: Operating system type: Windows
Operating system version:



It is difficult to read some values in FileZilla Server interface. Such received/sent bytes number etc.

I would like to propouse patch. It divide big numbers by groups, with three digits per each. It is much more easy to read.


Attachments (3)

make numbers user (82.5 KB ) - added by silamantex 15 years ago.
patch, sources and example
difference.png (82.7 KB ) - added by silamantex 15 years ago.
Example of result
OutputFormat.cpp (764 bytes ) - added by silamantex 15 years ago.
updated version 2009.03.05

Download all attachments as: .zip

Change History (7)

by silamantex, 15 years ago

patch, sources and example

by silamantex, 15 years ago

Attachment: difference.png added

Example of result

comment:1 by Tim Kosse, 15 years ago

Status: newmoreinfo

Thanks, some remarks:

  • cstringt.h, is that filea vailable on older versions of visual studio? (especially 2003)
  • in Unicode build it'll either fail to compile or there will be lots of additional conversions. Use _T()
  • Use GetLocaleInfo to get the proper separator character/string for number formatting. For example English locale uses comma and German locale uses dot, not spaces.

by silamantex, 15 years ago

Attachment: OutputFormat.cpp added

updated version 2009.03.05

comment:2 by silamantex, 15 years ago

Cc: silamantex@… added
Status: moreinfonew

I have no ability to check cstringt.h under VS2003. But I find in Internet that file should exist there.

Unicode and GetLocaleInfo() added. New version of .cpp attached.

comment:3 by silamantex, 15 years ago

Actually it is possible to remove "#include <cstringt.h>" from header OutputFormat.h . Because CString definition available through
<stdafx.h> -> <afxwin.h>

comment:4 by Tim Kosse, 15 years ago

Resolution: fixed
Status: newclosed

Thanks for the patch.

I've slightly adjusted it to get rid of expensive MakeReverse.

Note: See TracTickets for help on using tickets.