Opened 12 years ago

Last modified 12 years ago

#1524 closed Patch

show server information in window title

Reported by: tommywu Owned by:
Priority: normal Component: FileZilla Client
Keywords: Cc: tommywu, Tim Kosse
Component version: Operating system type:
Operating system version:

Description

show current connected server information in window title.

Attachments (2)

filezilla3_title_show_server.patch (856 bytes) - added by tommywu 12 years ago.
show server information in window title
filezilla_3.0.1_title_show_server.patch (1.3 KB) - added by tommywu 12 years ago.
also show information for quickconnect

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by tommywu

show server information in window title

comment:1 Changed 12 years ago by tommywu

also show information for quickconnect
File Added: filezilla_3.0.1_title_show_server.patch

Changed 12 years ago by tommywu

also show information for quickconnect

comment:2 Changed 12 years ago by tommywu

File Added: filezilla_3.0.1_title_show_server.patch

comment:3 Changed 12 years ago by Tim Kosse

I've committed a modified version:

  • The correct method to set the window title is SetWindowTitle
  • There's no need to add the same code in three different places, when in all of them the same method gets called. Added the title setting in CState::Connect instead
  • There's no guarantee that the update handler will be called if e.g. the window is minimized. Handling the disconnect event in CServer::SetServer is a proper solution
Note: See TracTickets for help on using tickets.