Specify default anonymous password

[eyebex]

This patch adds support for specifying a default
anonymous password to the GUI. The patch was done via
CVS diff -u and patches multiple files. Patches are a
little bigger than necessary because trailing spaces of
the affected files got trimmed.

[Tim Kosse]

Please move the trailing space stripping to a different
patch and submit it separately.

Also, can you please update all the language files so the
password input field exists in all languages? Else FileZilla
will crash if using the language files.

[eyebex]

"Trim trailing spaces only" patch

[eyebex]

Well, okay ... here's the patch that only trims trailing
spaces from the files my original patch modified. Please
apply it ASAP so I can easily diff my patch against the new
CVS contents.

[Tim Kosse]

Applied the cleanup patch.

[eyebex]

Here's the real thing, patched against new CVS contents.
I've deleted the old patch. The language files patch will
follow soon.

[eyebex]

Custom anonymous password patch

[eyebex]

Is there a reason why not to use a single "resource.h" file
for all languages? This would simplify adding controls to
the GUI. As a first step, here's a patch that strips all
trailing spaces from all language RC files and makes them
use the "resource.h" in the "source" directory, nothing
more. All other "resource.h" files in the individual
language directories can IMHO be deleted from CVS.

[Tim Kosse]

The language file patch fails to apply, several hundred
failed hunks.

[eyebex]

Sorry, I accidently trimmed trailing spaces in the patch,
too :-) Here's the original one.

[eyebex]

Use common resource.h and traim trailing spaces

[Tim Kosse]

Applied.

I want to release FZ 2.2.14 tomorrow, would be nice to have
your patch included.

[eyebex]

Changes are not yet visible in CVS. As soon as they are, I
will be working on the language files. Expect my patch today.

Have you also applied CustomAnonPwd.patch? If not, you could
do so in the meantime to review my changes.

PS: I'm going to write you an e-mail with my ICQ address in
case you prefer faster communication.

[Tim Kosse]

So far your patch looks good

[eyebex]

Oh man, editing all those RC files was a real pain in the
butt, now I know why you wanted me to do it ;-) Anyways, the
patch is ready and I also corrected a few glitches like too
short label boxes (cutting off words) etc.

[eyebex]

Add the new anonymous password edit field to all languages

[Tim Kosse]

Bad news, it seems that Visual Studio readds all the nasty
trailing spaces in the resource files :/

[eyebex]

Yes, as soon as you use VC's resource editor, trailing
spaces get again added to the RC files (it also changes a
whole lot of other stuff, as it seems). That's what made
creating this last patch so hard. I had to edit the RC files
in VC, then only copy the IDD_CONNECTION2 dialog to a
cleanly checked-out file using UltraEdit (which strips
trailing spaces). However, you can apply all patches for the
release today. I'm currently searching for a (free / open
source) RC editor which doesn't add trailing spaces.
Translators should then be advised to use such an external
tool instead of VC (most of them won't have VC anyway, I guess).

[Tim Kosse]

Stupid Visual Studio does not even understand #include
"../../resource.h", upon saving the file, it becomes
#include "resource.h" again. I've added a small script to
CVS which will fix this.
Unless Microsoft fixes its horribly broken software (which
will never happen), the whitespace and include problems will
have to stay.

I've applied your patch, though I slightly modified the
wording and moved the input field to the bottom, Users don't
like if things move around.