Opened 15 years ago

Last modified 6 years ago

#1480 closed Patch

Specify default anonymous password

Reported by: eyebex Owned by:
Priority: normal Component: Other
Keywords: Cc: eyebex, Tim Kosse
Component version: Operating system type:
Operating system version:

Description

This patch adds support for specifying a default
anonymous password to the GUI. The patch was done via
CVS diff -u and patches multiple files. Patches are a
little bigger than necessary because trailing spaces of
the affected files got trimmed.

Attachments (4)

FileZillaTrimSpaces.patch (203.4 KB ) - added by eyebex 15 years ago.
"Trim trailing spaces only" patch
CustomAnonPwd.patch (14.0 KB ) - added by eyebex 15 years ago.
Custom anonymous password patch
Language.zip (237.7 KB ) - added by eyebex 15 years ago.
Use common resource.h and traim trailing spaces
LanguageAnonPwd.patch (70.7 KB ) - added by eyebex 15 years ago.
Add the new anonymous password edit field to all languages

Download all attachments as: .zip

Change History (18)

comment:1 by Tim Kosse, 15 years ago

Please move the trailing space stripping to a different
patch and submit it separately.

Also, can you please update all the language files so the
password input field exists in all languages? Else FileZilla
will crash if using the language files.

by eyebex, 15 years ago

Attachment: FileZillaTrimSpaces.patch added

"Trim trailing spaces only" patch

comment:2 by eyebex, 15 years ago

Well, okay ... here's the patch that only trims trailing
spaces from the files my original patch modified. Please
apply it ASAP so I can easily diff my patch against the new
CVS contents.

comment:3 by Tim Kosse, 15 years ago

Applied the cleanup patch.

comment:4 by eyebex, 15 years ago

Here's the real thing, patched against new CVS contents.
I've deleted the old patch. The language files patch will
follow soon.

by eyebex, 15 years ago

Attachment: CustomAnonPwd.patch added

Custom anonymous password patch

comment:5 by eyebex, 15 years ago

Is there a reason why not to use a single "resource.h" file
for all languages? This would simplify adding controls to
the GUI. As a first step, here's a patch that strips all
trailing spaces from all language RC files and makes them
use the "resource.h" in the "source" directory, nothing
more. All other "resource.h" files in the individual
language directories can IMHO be deleted from CVS.

comment:6 by Tim Kosse, 15 years ago

The language file patch fails to apply, several hundred
failed hunks.

comment:7 by eyebex, 15 years ago

Sorry, I accidently trimmed trailing spaces in the patch,
too :-) Here's the original one.

by eyebex, 15 years ago

Attachment: Language.zip added

Use common resource.h and traim trailing spaces

comment:8 by Tim Kosse, 15 years ago

Applied.

I want to release FZ 2.2.14 tomorrow, would be nice to have
your patch included.

comment:9 by eyebex, 15 years ago

Changes are not yet visible in CVS. As soon as they are, I
will be working on the language files. Expect my patch today.

Have you also applied CustomAnonPwd.patch? If not, you could
do so in the meantime to review my changes.

PS: I'm going to write you an e-mail with my ICQ address in
case you prefer faster communication.

comment:10 by Tim Kosse, 15 years ago

So far your patch looks good

comment:11 by eyebex, 15 years ago

Oh man, editing all those RC files was a real pain in the
butt, now I know why you wanted me to do it ;-) Anyways, the
patch is ready and I also corrected a few glitches like too
short label boxes (cutting off words) etc.

by eyebex, 15 years ago

Attachment: LanguageAnonPwd.patch added

Add the new anonymous password edit field to all languages

comment:12 by Tim Kosse, 15 years ago

Bad news, it seems that Visual Studio readds all the nasty
trailing spaces in the resource files :/

comment:13 by eyebex, 15 years ago

Yes, as soon as you use VC's resource editor, trailing
spaces get again added to the RC files (it also changes a
whole lot of other stuff, as it seems). That's what made
creating this last patch so hard. I had to edit the RC files
in VC, then only copy the IDD_CONNECTION2 dialog to a
cleanly checked-out file using UltraEdit (which strips
trailing spaces). However, you can apply all patches for the
release today. I'm currently searching for a (free / open
source) RC editor which doesn't add trailing spaces.
Translators should then be advised to use such an external
tool instead of VC (most of them won't have VC anyway, I guess).

comment:14 by Tim Kosse, 15 years ago

Stupid Visual Studio does not even understand #include
"../../resource.h", upon saving the file, it becomes
#include "resource.h" again. I've added a small script to
CVS which will fix this.
Unless Microsoft fixes its horribly broken software (which
will never happen), the whitespace and include problems will
have to stay.

I've applied your patch, though I slightly modified the
wording and moved the input field to the bottom, Users don't
like if things move around.

Note: See TracTickets for help on using tickets.