3.67.0 fails to build on Windows

[lazka]

With GCC:

  ../../../FileZilla-3.67.0/src/interface/verifyhostkeydialog.cpp: In static member function 'static void CVerifyHostkeyDialog::ShowVerificationDialog(wxWindow*, CHostKeyNotification&)':
  ../../../FileZilla-3.67.0/src/interface/verifyhostkeydialog.cpp:63:88: error: operands to '?:' have different types 'const wxString' and 'std::wstring' {aka 'std::__cxx11::basic_string<wchar_t>'}
     63 |         inner->Add(new wxStaticText(box, nullID, notification.hostKeyAlgorithm.empty() ? _("Unknown") : LabelEscape(notification.hostKeyAlgorithm)));
        |                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ../../../FileZilla-3.67.0/src/interface/verifyhostkeydialog.cpp:63:88: note:   and each type can be converted to the other

With Clang:

../../../FileZilla-3.67.0/src/interface/verifyhostkeydialog.cpp:63:81: error: conditional expression is ambiguous; 'const wxString' can be converted to 'std::wstring' (aka 'basic_string<wchar_t>') and vice versa
  63 |         inner->Add(new wxStaticText(box, nullID, notification.hostKeyAlgorithm.empty() ? _("Unknown") : LabelEscape(notification.hostKeyAlgorithm)));
     |                                                                                        ^ ~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[lazka]

This seems to make it build:

src/interface/sftp_crypt_info_dlg.cpp

@@ -28 +28 @@
     {
         auto [box, inner] = lay.createStatBox(main, _("Server host key"), 2);
         inner->Add(new wxStaticText(box, nullID, _("Algorithm:")));
-        inner->Add(new wxStaticText(box, nullID, pNotification->hostKeyAlgorithm.empty() ? _("Unknown") : LabelEscape(pNotification->hostKeyAlgorithm)));
+        inner->Add(new wxStaticText(box, nullID, pNotification->hostKeyAlgorithm.empty() ? std::wstring(_("Unknown")) : LabelEscape(pNotification->hostKeyAlgorithm)));
         inner->Add(new wxStaticText(box, nullID, _("Fingerprints:")));
         inner->Add(new wxStaticText(box, nullID, LabelEscape(pNotification->hostKeyFingerprint)));
     }

src/interface/verifyhostkeydialog.cpp

@@ -60 +60 @@
     inner->Add(new wxStaticText(box, nullID, _("Host:")));
     inner->Add(new wxStaticText(box, nullID, LabelEscape(host)));
     inner->Add(new wxStaticText(box, nullID, _("Hostkey algorithm:")));
-    inner->Add(new wxStaticText(box, nullID, notification.hostKeyAlgorithm.empty() ? _("Unknown") : LabelEscape(notification.hostKeyAlgorithm)));
+    inner->Add(new wxStaticText(box, nullID, notification.hostKeyAlgorithm.empty() ? std::wstring(_("Unknown")) : LabelEscape(notification.hostKeyAlgorithm)));
     inner->Add(new wxStaticText(box, nullID, _("Fingerprints:")));
     inner->Add(new wxStaticText(box, nullID, LabelEscape(notification.hostKeyFingerprint)));