Event Handle Leak Bugfix submission for winsftp.c (in fzsftp.exe)

[Tobias Giesen]

Hello,

when downloading a larger file, fzsftp.exe creates hundreds and thousands
of Windows events.

Here's the simple fix for the do_select function, around line 545 of
winsftp.c:

if ((netevent==0)

(netevent==INVALID_HANDLE_VALUE))

netevent = CreateEvent(NULL, false, false, NULL);

I have submitted this fix to the PuTTY project also, but I am unsure if they will read my email.

[Tobias Giesen]

The source code was apparently broken by pasting, please add the logical OR operator where appropriate.

[Tobias Giesen]

maybe this should be added?

else

ResetEvent(netevent);

[Tobias Giesen]

I got a reply from PuTTY team with an alternate fix which I'm testing now.

[Tim Kosse]

That's an interesting bug. Something changed in PuTTY a while ago that causes this bug to be triggered, yet it has existed unnoticed for quite some time.

Would you mind sharing the fix the PuTTY team has in mind?

[Tobias Giesen]

Patch from the PuTTY Project

[Tobias Giesen]

Hello,
I have added the patch as an attachment.

[Tobias Giesen]

Hello,
after some testing, I prefer my original fix. The other patch seems to be preventing downloads from starting. I think my fix will be good enough for the moment.

[Tobias Giesen]

Final (Correted)Patch from the PuTTY Project

[Tobias Giesen]

Hello,
I received a corrected patch from the PuTTY team, which works fine. I have attached it here (the second attachment).