Opened 3 years ago
Last modified 3 years ago
#12068 new Bug report
Event Handle Leak Bugfix submission for winsftp.c (in fzsftp.exe)
|Reported by:||Tobias Giesen||Owned by:|
|Component version:||Operating system type:||Windows|
|Operating system version:|
when downloading a larger file, fzsftp.exe creates hundreds and thousands
of Windows events.
Here's the simple fix for the do_select function, around line 545 of
netevent = CreateEvent(NULL, false, false, NULL);
I have submitted this fix to the PuTTY project also, but I am unsure if they will read my email.
Change History (9)
comment:1 by , 3 years ago
comment:2 by , 3 years ago
maybe this should be added?
comment:3 by , 3 years ago
I got a reply from PuTTY team with an alternate fix which I'm testing now.
comment:4 by , 3 years ago
|Status:||new → moreinfo|
That's an interesting bug. Something changed in PuTTY a while ago that causes this bug to be triggered, yet it has existed unnoticed for quite some time.
Would you mind sharing the fix the PuTTY team has in mind?
by , 3 years ago
Patch from the PuTTY Project
comment:5 by , 3 years ago
|Status:||moreinfo → new|
I have added the patch as an attachment.
comment:6 by , 3 years ago
after some testing, I prefer my original fix. The other patch seems to be preventing downloads from starting. I think my fix will be good enough for the moment.
by , 3 years ago
Final (Correted)Patch from the PuTTY Project
comment:7 by , 3 years ago
I received a corrected patch from the PuTTY team, which works fine. I have attached it here (the second attachment).
The source code was apparently broken by pasting, please add the logical OR operator where appropriate.