FileZilla 3.37.3 does not build with libfilezilla 0.13.2

[yan12125]

Need to backport ​https://svn.filezilla-project.org/filezilla?view=revision&revision=8942 for libfilezilla

g++ -DHAVE_CONFIG_H -I. -I../../src/include  -I./../include   -I/usr/lib/wx/include/gtk3-unicode-3.0 -I/usr/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__  -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/libffi-3.2.1/include -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/uuid -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -pthread  -D_FORTIFY_SOURCE=2 -fpch-preprocess  -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -Wall -g -MT filezilla-queue.o -MD -MP -MF .deps/filezilla-queue.Tpo -c -o filezilla-queue.o `test -f 'queue.cpp' || echo './'`queue.cpp
queue.cpp: In member function ‘void CFileItem::SetTargetFile(const wxString&)’:
queue.cpp:333:71: error: no matching function for call to ‘to_wstring(const wxString&)’
   m_targetFile = fz::sparse_optional<std::wstring>(fz::to_wstring(file));
                                                                       ^
In file included from /usr/include/libfilezilla/libfilezilla.hpp:7,
                 from ../../src/include/libfilezilla_engine.h:12,
                 from filezilla.h:4:
/usr/include/libfilezilla/string.hpp:145:31: note: candidate: ‘std::__cxx11::wstring fz::to_wstring(const string&)’
 std::wstring FZ_PUBLIC_SYMBOL to_wstring(std::string const& in);
                               ^~~~~~~~~~
/usr/include/libfilezilla/string.hpp:145:31: note:   no known conversion for argument 1 from ‘const wxString’ to ‘const string&’ {aka ‘const std::__cxx11::basic_string<char>&’}
/usr/include/libfilezilla/string.hpp:148:38: note: candidate: ‘std::__cxx11::wstring fz::to_wstring(const wstring&)’
 inline std::wstring FZ_PUBLIC_SYMBOL to_wstring(std::wstring const& in) { return in; }
                                      ^~~~~~~~~~
/usr/include/libfilezilla/string.hpp:148:38: note:   no known conversion for argument 1 from ‘const wxString’ to ‘const wstring&’ {aka ‘const std::__cxx11::basic_string<wchar_t>&’}
/usr/include/libfilezilla/string.hpp:152:98: note: candidate: ‘template<class Arg> typename std::enable_if<std::is_arithmetic<typename std::decay<_Tp>::type>::value, std::__cxx11::basic_string<wchar_t> >::type fz::to_wstring(Arg&&)’
 inline typename std::enable_if<std::is_arithmetic<std::decay_t<Arg>>::value, std::wstring>::type to_wstring(Arg && arg)
                                                                                                  ^~~~~~~~~~
/usr/include/libfilezilla/string.hpp:152:98: note:   template argument deduction/substitution failed:
/usr/include/libfilezilla/string.hpp: In substitution of ‘template<class Arg> typename std::enable_if<std::is_arithmetic<typename std::decay<_Tp>::type>::value, std::__cxx11::basic_string<wchar_t> >::type fz::to_wstring(Arg&&) [with Arg = const wxString&]’:
queue.cpp:333:71:   required from here
/usr/include/libfilezilla/string.hpp:152:98: error: no type named ‘type’ in ‘struct std::enable_if<false, std::__cxx11::basic_string<wchar_t> >’

Tested on Arch Linux x86_64 and MacPorts with macOS Mojave.

[Tim Kosse]

libfilezilla 0.14.0 has been released.