Underlinking issue (undefined reference to `fz::random_bytes(unsigned long)' with `-Wl,--no-undefined`)

[Rémi Verschelde]

FileZilla 3.26.1 does not build on Mageia due to an underlinking issue [0]:

libtool: link: g++ -I/usr/lib64/wx/include/ -I/usr/lib64/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -Wall -std=gnu++14 -pthread -Wl,--export-dynamic -pthread -Wl,--as-needed -Wl,--no-undefined -Wl,-z -Wl,relro -Wl,-O1 -Wl,--build-id -Wl,--enable-new-dtags -o filezilla filezilla-aboutdialog.o filezilla-asksavepassworddialog.o filezilla-asyncrequestqueue.o filezilla-aui_notebook_ex.o filezilla-auto_ascii_files.o filezilla-bookmarks_dialog.o filezilla-buildinfo.o filezilla-chmoddialog.o filezilla-clearprivatedata.o filezilla-cmdline.o filezilla-commandqueue.o filezilla-conditionaldialog.o filezilla-context_control.o filezilla-customheightlistctrl.o filezilla-defaultfileexistsdlg.o filezilla-dialogex.o filezilla-dndobjects.o filezilla-dragdropmanager.o filezilla-drop_target_ex.o filezilla-edithandler.o filezilla-encoding_converter.o filezilla-export.o filezilla-fileexistsdlg.o filezilla-filelistctrl.o filezilla-filelist_statusbar.o filezilla-FileZilla.o filezilla-filter.o filezilla-filter_conditions_dialog.o filezilla-filteredit.o filezilla-file_utils.o filezilla-fzputtygen_interface.o filezilla-graphics.o filezilla-import.o filezilla-inputdialog.o filezilla-ipcmutex.o filezilla-led.o filezilla-listctrlex.o filezilla-listingcomparison.o filezilla-local_recursive_operation.o filezilla-locale_initializer.o filezilla-LocalListView.o filezilla-LocalTreeView.o filezilla-loginmanager.o filezilla-Mainfrm.o filezilla-manual_transfer.o filezilla-menu_bar.o filezilla-msgbox.o filezilla-netconfwizard.o filezilla-Options.o filezilla-password_crypto.o filezilla-power_management.o filezilla-queue.o filezilla-queue_storage.o filezilla-QueueView.o filezilla-queueview_failed.o filezilla-queueview_successful.o filezilla-quickconnectbar.o filezilla-recentserverlist.o filezilla-recursive_operation.o filezilla-recursive_operation_status.o filezilla-remote_recursive_operation.o filezilla-RemoteListView.o filezilla-RemoteTreeView.o filezilla-search.o filezilla-serverdata.o settings/filezilla-optionspage.o settings/filezilla-optionspage_connection.o settings/filezilla-optionspage_connection_active.o settings/filezilla-optionspage_connection_ftp.o settings/filezilla-optionspage_connection_passive.o settings/filezilla-optionspage_connection_sftp.o settings/filezilla-optionspage_dateformatting.o settings/filezilla-optionspage_debug.o settings/filezilla-optionspage_edit.o settings/filezilla-optionspage_edit_associations.o settings/filezilla-optionspage_fileexists.o settings/filezilla-optionspage_filelists.o settings/filezilla-optionspage_filetype.o settings/filezilla-optionspage_ftpproxy.o settings/filezilla-optionspage_interface.o settings/filezilla-optionspage_language.o settings/filezilla-optionspage_logging.o settings/filezilla-optionspage_proxy.o settings/filezilla-optionspage_sizeformatting.o settings/filezilla-optionspage_themes.o settings/filezilla-optionspage_transfer.o settings/filezilla-optionspage_updatecheck.o settings/filezilla-settingsdialog.o filezilla-sftp_crypt_info_dlg.o filezilla-sitemanager.o filezilla-sitemanager_dialog.o filezilla-sizeformatting.o filezilla-speedlimits_dialog.o filezilla-splitter.o filezilla-state.o filezilla-statusbar.o filezilla-statuslinectrl.o filezilla-StatusView.o filezilla-systemimagelist.o filezilla-textctrlex.o filezilla-themeprovider.o filezilla-timeformatting.o filezilla-toolbar.o filezilla-treectrlex.o filezilla-updater.o filezilla-update_dialog.o filezilla-verifycertdialog.o filezilla-verifyhostkeydialog.o filezilla-view.o filezilla-viewheader.o filezilla-volume_enumerator.o filezilla-welcome_dialog.o filezilla-window_state_manager.o filezilla-wrapengine.o filezilla-wxfilesystem_blob_handler.o filezilla-xh_text_ex.o filezilla-xmlfunctions.o filezilla-xrc_helper.o filezilla-prefix.o  ../engine/libengine.a -lfilezilla -lpthread -lpugixml -lnettle -lhogweed -lgnutls ../dbus/libfzdbus.a -ldbus-1 -L/usr/lib64 -lwx_gtk2u_aui-3.0 -lwx_gtk2u_xrc-3.0 -lwx_gtk2u_adv-3.0 -lwx_gtk2u_core-3.0 -lwx_baseu_xml-3.0 -lwx_baseu-3.0 -lsqlite3 -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgmodule-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype -pthread
filezilla-asksavepassworddialog.o: In function `CAskSavePasswordDialog::OnOk(wxCommandEvent&)':
/home/akien/Mageia/Checkout/filezilla/BUILD/filezilla-3.26.1/src/interface/asksavepassworddialog.cpp:50: undefined reference to `fz::random_bytes(unsigned long)'
filezilla-password_crypto.o: In function `private_key::generate()':
/home/akien/Mageia/Checkout/filezilla/BUILD/filezilla-3.26.1/src/interface/password_crypto.cpp:40: undefined reference to `fz::random_bytes(unsigned long)'
/home/akien/Mageia/Checkout/filezilla/BUILD/filezilla-3.26.1/src/interface/password_crypto.cpp:45: undefined reference to `fz::random_bytes(unsigned long)'
settings/filezilla-optionspage_interface.o: In function `COptionsPageInterface::SavePasswordOption()':
/home/akien/Mageia/Checkout/filezilla/BUILD/filezilla-3.26.1/src/interface/settings/optionspage_interface.cpp:113: undefined reference to `fz::random_bytes(unsigned long)'
collect2: error: ld returned 1 exit status
Makefile:928: recipe for target 'filezilla' failed

I haven't tested but I suppose the issue only happens when using the -Wl,--no-undefined linker parameter, which is enforced by several distros in their packaging to prevent underlinking issues [0].

[0] ​https://wiki.mageia.org/en/Underlinking_issues_in_packaging

[Rémi Verschelde]

RPM build log

[Rémi Verschelde]

Nevermind, I found this upstream patch for libfilezilla in the Fedora package: ​http://pkgs.fedoraproject.org/cgit/rpms/libfilezilla.git/tree/libfilezilla-0.9.2-util.patch

This can likely be closed.