Opened 8 years ago
Closed 8 years ago
#11044 closed Patch (fixed)
Status text is wrong color, unreadable if using a dark theme
| Reported by: | Markus Kitsinger | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | FileZilla Client |
| Keywords: | UI, GUI, Text, Theme, WX | Cc: | |
| Component version: | Operating system type: | Linux | |
| Operating system version: |
Description
When using a dark theme, the standard status messages in the client can be unreadable.
This patch changes the default color of the text in the statusview widget from wxSYS_COLOUR_WINDOWTEXT to wxSYS_COLOUR_LISTBOXTEXT. The background color is wxSYS_COLOUR_LISTBOX, so this made the most sense to me.
I haven't tested the patch with a light theme, or on any other OSes, but I imagine it wouldn't cause any problems. The patch itself is one I wrote back in 2014 for a debian package, but it should still apply fine.
Attachments (1)
Change History (2)
by , 8 years ago
| Attachment: | 20_statusview-text-color-fix.patch added |
|---|
comment:1 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Thanks, applied.
The beauty of old code. When the code to set the foreground color was first written, wxSYS_COLOUR_LISTBOXTEXT had not been invented yet.
On platforms other than wxGTK, wxSYS_COLOUR_LISTBOXTEXT maps to wxSYS_COLOUR_WINDOWTEXT.