OSX autoupdate fails

[rcuisnier]

Hello,

On OSX 10.9.5 Maverciks, Filezilla 3.9 and 3.10 fails to auto upgrade itself.

1- It downloads a package in
~/FileZilla_3.10.0.1_macosx-x86.app.tar.bz2
2- then extract it
as ~/FileZilla_3.10.0.1_macosx-x86.app
3- It fails to replace (maybe because Filezilla is still opened)
/Applications/Filezilla.app

I have several other problems with this mecanism :
1- The downloaded path should be :
~/Downloads/FileZilla_3.10.0.1_macosx-x86.app.tar.bz2
instead of
~/FileZilla_3.10.0.1_macosx-x86.app.tar.bz2
Or maybe provide a settings to choose the download path

2- After I tried to manually extract
~/FileZilla_3.10.0.1_macosx-x86.app.tar.bz2
When I doubleclick on
~/FileZilla_3.10.0.1_macosx-x86.app
OSX error said package is broken.

But I can rightclick and then choose explore package in order to find the Filezilla.app file.

For now I still upgrade Filezilla manually...

I think the autoupgrade method could be slightly enahanced...

Thanx.

[Sebastiaan]

I'm not sure about the main issue, but I can confirm point 1. The autoupdate notification says something like "the file has been placed in your Downloads folder", but it actually places it somewhere else.

I think this is because GetDownloadDir() in interface/file_utils.cpp does not return the proper download directory (~/Downloads) on OS X.

[Sebastiaan]

We can use wxStandardPaths::GetUserDir(Dir_Downloads) to replace the GetDownloadDir() function, once we depend on wxWidgets >= 3.1.