Ticket #8190 (new Patch)

Opened 21 months ago

Last modified 20 months ago

Event queue processing modification to improve filezilla client resposibility

Reported by: esminis Owned by:
Priority: normal Component: FileZilla Client
Keywords: responsibility Cc:
Operating system type: Operating system version:

Description

Filezilla lags really hard if operations with a lot of files are executed(like upload 100K files with skipping existing files). This happens because wxWidgets event queue gets jammed and everything gets stuck in processing pending events.

This can be fixed by supporting wxWidgets 2.9 and using QueueEvent instead of PostEvent or with fix I attached(it makes sure that only some events are processed from pending event queue in one iteration).

Attachments

filezilla.patch Download (1.9 KB) - added by esminis 21 months ago.

Change History

Changed 21 months ago by esminis

Changed 20 months ago by codesquid

  • status changed from new to moreinfo

Thanks for the patch.

Under which operating systems have you tested your patch? Under wxGTK and wxMAC, some of the generic controls have some subtle problems related to event processing. I'm worried that this change might cause stability issues.

Changed 20 months ago by esminis

  • status changed from moreinfo to new

I have tested only on Linux wxGtk it worked well for me. Im not 100% sure that it wont couse problems, but currently can`t imagine scenario where it could create problems(unless there are really bad hacks in wx).

One more thin I forgot to mention is that it might decrease file upload speed if idleCounter is really low number, but it will increase filezilla responsibility alot.

Note: See TracTickets for help on using tickets.