Opened 11 years ago
Closed 7 years ago
#8976 closed Patch (outdated)
generic proxy per site
Reported by: | Tommy Wu | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | FileZilla Client |
Keywords: | Cc: | ||
Component version: | Operating system type: | ||
Operating system version: |
Description
allow to define generic proxy per site.
the rule is:
- if define generic proxy per site, it will use it (ignore bypass proxy setting)
- if no generic proxy per site, and if bypass proxy, it will connect directly
- if no generic proxy per site, and if not bypass proxy, it will use system's generic proxy if defined.
Attachments (5)
Change History (7)
by , 11 years ago
Attachment: | filezilla_3.7.3_proxy_per_site.patch added |
---|
comment:1 by , 10 years ago
Status: | new → moreinfo |
---|
Thanks for the update.
Most of the patch already looks good, a couple of comments though:
- This patch changes the schema of the queue database. You need to add migration code so that older queues can still be loaded. In CQueueStorage::Impl::MigrateSchema() the new user_version should be 2.
- If no proxy is set, store NULLs in the database for the other proxy fields
- The SOCKS4 generic proxy type is missing
- Indentation seems off in a few places. FileZilla's source is indented with tabs
- Please base the patch against SVN trunk
by , 10 years ago
Attachment: | filezilla_svn6189_proxy_per_site.patch added |
---|
fix all issue and update the patch to svn 6189
by , 10 years ago
Attachment: | filezilla_svn6189_proxy_per_site_v2.patch added |
---|
fix error for using m_pEngine->GetOptions()
comment:2 by , 7 years ago
Resolution: | → outdated |
---|---|
Status: | moreinfo → closed |
Note:
See TracTickets
for help on using tickets.
generic proxy per site