Opened 6 years ago

Closed 3 years ago

#8976 closed Patch (outdated)

generic proxy per site

Reported by: Tommy Wu Owned by:
Priority: normal Component: FileZilla Client
Keywords: Cc:
Component version: Operating system type:
Operating system version:

Description

allow to define generic proxy per site.
the rule is:

  1. if define generic proxy per site, it will use it (ignore bypass proxy setting)
  2. if no generic proxy per site, and if bypass proxy, it will connect directly
  3. if no generic proxy per site, and if not bypass proxy, it will use system's generic proxy if defined.

Attachments (5)

filezilla_3.7.3_proxy_per_site.patch (29.9 KB) - added by Tommy Wu 6 years ago.
generic proxy per site
filezilla_3.9.0.6_proxy_per_site.patch (28.3 KB) - added by Tommy Wu 5 years ago.
patch for 3.9.0.6
filezilla_svn6189_proxy_per_site.patch (30.0 KB) - added by Tommy Wu 5 years ago.
fix all issue and update the patch to svn 6189
filezilla_svn6189_proxy_per_site_v2.patch (30.0 KB) - added by Tommy Wu 5 years ago.
fix error for using m_pEngine->GetOptions()
filezilla_svn6189_proxy_per_site_v3.patch (30.0 KB) - added by Tommy Wu 5 years ago.
fix sftp proxy type

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by Tommy Wu

generic proxy per site

Changed 5 years ago by Tommy Wu

patch for 3.9.0.6

comment:1 Changed 5 years ago by Tim Kosse

Status: newmoreinfo

Thanks for the update.

Most of the patch already looks good, a couple of comments though:

  1. This patch changes the schema of the queue database. You need to add migration code so that older queues can still be loaded. In CQueueStorage::Impl::MigrateSchema() the new user_version should be 2.
  1. If no proxy is set, store NULLs in the database for the other proxy fields
  1. The SOCKS4 generic proxy type is missing
  1. Indentation seems off in a few places. FileZilla's source is indented with tabs
  1. Please base the patch against SVN trunk

Changed 5 years ago by Tommy Wu

fix all issue and update the patch to svn 6189

Changed 5 years ago by Tommy Wu

fix error for using m_pEngine->GetOptions()

Changed 5 years ago by Tommy Wu

fix sftp proxy type

comment:2 Changed 3 years ago by Kurt McKee

Resolution: outdated
Status: moreinfoclosed
Note: See TracTickets for help on using tickets.