Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8852 closed Patch (fixed)

missing fzputtygen when creating FileZilla.app bundle on Mac OS X

Reported by: Mojca Miklavec Owned by:
Priority: normal Component: FileZilla Client
Keywords: Cc:
Component version: Operating system type: OS X
Operating system version:

Description

Building FileZilla on Mac OS X fails with fzputtygen: No such file or directory because of the wrong building order:

cp -f fzsftp ../../FileZilla.app/Contents/MacOS/fzsftp
cp -f fzputtygen ../../FileZilla.app/Contents/MacOS/fzputtygen
cp: fzputtygen: No such file or directory
make[3]: *** [../../FileZilla.app/Contents/MacOS/fzsftp] Error 1
make[3]: *** Waiting for unfinished jobs....
libtool: link: /usr/bin/clang -pipe -Os -arch x86_64 -Wall -g -fexceptions -Wl,-headerpad_max_install_names -arch x86_64 -o fzputtygen fzputtygen-cmdgen.o fzputtygen-import.o fzputtygen-notiming.o fzputtygen-tree234.o  -L/opt/local/lib unix/libfzputtycommon_ux.a libfzputtycommon.a

The following trivial patch for version 3.7.3 should probably fix it:

--- a/src/putty/Makefile.am
+++ b/src/putty/Makefile.am
@@ -81,7 +81,7 @@ if MACAPPBUNDLE
 noinst_DATA = $(top_builddir)/FileZilla.app/Contents/MacOS/fzsftp$(EXEEXT)
 endif
  
-$(top_builddir)/FileZilla.app/Contents/MacOS/fzsftp$(EXEEXT): fzsftp
+$(top_builddir)/FileZilla.app/Contents/MacOS/fzsftp$(EXEEXT): fzsftp fzputtygen
 	mkdir -p $(top_builddir)/FileZilla.app/Contents/MacOS
 	cp -f fzsftp $(top_builddir)/FileZilla.app/Contents/MacOS/fzsftp
 	cp -f fzputtygen $(top_builddir)/FileZilla.app/Contents/MacOS/fzputtygen

Attachments (1)

patch-src-putty-Makefile.am.diff (614 bytes) - added by Mojca Miklavec 6 years ago.
A patch to build fzputtygen before FileZilla.app bundle

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Mojca Miklavec

A patch to build fzputtygen before FileZilla.app bundle

comment:1 Changed 6 years ago by Mojca Miklavec

Type: Bug reportPatch

comment:2 Changed 6 years ago by Tim Kosse

Resolution: fixed
Status: newclosed

Thanks.

comment:3 Changed 6 years ago by Mojca Miklavec

Thanks a lot for the fix. Is there any chance to fix compatibility with wxWidgets 3.0 as well? #8272

Note: See TracTickets for help on using tickets.