add digest support for http proxy

[Tommy Wu]

this patch will add digest method support for http proxy

[Tommy Wu]

add digest support for http proxy

[Tim Kosse]

#include <nettle/md5-compat.h>

You need to add a configure check for Nettle and also explicitly link against nettle.

[Tommy Wu]

add digest support for http proxy (with internal md5 function)

[Tommy Wu]

Replying to codesquid:

#include <nettle/md5-compat.h>

You need to add a configure check for Nettle and also explicitly link against nettle.

please try this version, it include a internal md5 function, so we don't need md5 lib from nettle or openssl.

[Tommy Wu]

try digest first, if fail, try basic again

[Tommy Wu]

patch for 3.9.0.6, use md5 related function from nettle

[Tommy Wu]

I just update the patch for 3.9.0.6.
Do we still need to check the nettle in configure? Because based on the filezilla compile documentation, it should build nettle first, then build gnutls based on nettle. so it should already have nettle.

[Tommy Wu]

check nettle/md5.h, md5_init(), md5_update(), md5_digest() in configure

[Tim Kosse]

Thanks for the update. A couple of comments:

1) I wonder whether we even need nettle. There already is a MD5 implementation in the source, though only in the fzsftp component: src/putty/sshmd5.c
Adopting it for use in the proxy code should be fairly straightforward, as is done similarly in the auto-updater with sshsh512.c

2) There's heap corruption wrt. pBody, in at least one place you're deleting the buffer without breaking the loop. Consider using std::unique_ptr instead of doing manual memory management.

3) There's a lot of code duplication with building the header, sending it, then receiving and parsing the response. Moving the common parts into separate functions would simplify the code a lot.

4) In wx3, wxString::Format is actually a type-safe template function as opposed to the C-style variadic function used in wx2.8 and earlier. Passing wxString arguments using c_str() is no longer needed, it only reduces performance.

5) Functions like wxString::Lower are locale-aware. Converting a string containing the uppercase letter I and then comparing against a string containing the letter i will fail if the locale is set to Turkish. See ​http://en.wikipedia.org/wiki/Dotted_and_dotless_I for details. Use MakeLowerAscii from src/include/misc.h

6) wxString has a default constructor, there's no need to construct it from an empty string literal.

7) Instead of comparing against the empty string literal, use wxString::empty()