Transfer - Speed Limits - Enable Checked State Incorrect on Restart

[Mitchell Jareo]

To reproduce...

1. Enable speed limits
2. Exit Client
3. Restart Client

The menu item is not checked but speed limits are seemingly enabled.
Selecting the menu item will not set check on.
Selecting the menu item again will set check on.

[Jorrit Schippers]

Also happens on Ubuntu. The code doesn't check the speed limit option on startup.

The code block

bool enable = COptions::Get()->GetOptionVal(OPTION_SPEEDLIMIT_ENABLE) != 0;

int downloadLimit = COptions::Get()->GetOptionVal(OPTION_SPEEDLIMIT_INBOUND);
int uploadLimit = COptions::Get()->GetOptionVal(OPTION_SPEEDLIMIT_OUTBOUND);

if (!downloadLimit && !uploadLimit)
	enable = false;

Check(XRCID("ID_MENU_TRANSFER_SPEEDLIMITS_ENABLE"), enable);

from CMenuBar::OnOptionChanged also needs to be executed in CMenuBar* CMenuBar::Load(CMainFrame* pMainFrame). My C++ knowledge is not sufficient enough to abstract that code to a separate function, but I will attach a patch where I copy the code.

[Tim Kosse]

Thanks. I've put it into a function and committed the fix.