Opened 7 years ago

Closed 5 years ago

#8190 closed Patch (fixed)

Event queue processing modification to improve filezilla client resposibility

Reported by: Tautvydas Andrikys Owned by:
Priority: normal Component: FileZilla Client
Keywords: responsibility Cc:
Component version: Operating system type:
Operating system version:

Description

Filezilla lags really hard if operations with a lot of files are executed(like upload 100K files with skipping existing files). This happens because wxWidgets event queue gets jammed and everything gets stuck in processing pending events.

This can be fixed by supporting wxWidgets 2.9 and using QueueEvent instead of PostEvent or with fix I attached(it makes sure that only some events are processed from pending event queue in one iteration).

Attachments (1)

filezilla.patch (1.9 KB) - added by Tautvydas Andrikys 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Tautvydas Andrikys

Attachment: filezilla.patch added

comment:1 Changed 7 years ago by Tim Kosse

Status: newmoreinfo

Thanks for the patch.

Under which operating systems have you tested your patch? Under wxGTK and wxMAC, some of the generic controls have some subtle problems related to event processing. I'm worried that this change might cause stability issues.

comment:2 Changed 7 years ago by Tautvydas Andrikys

Status: moreinfonew

I have tested only on Linux wxGtk it worked well for me. Im not 100% sure that it wont couse problems, but currently can`t imagine scenario where it could create problems(unless there are really bad hacks in wx).

One more thin I forgot to mention is that it might decrease file upload speed if idleCounter is really low number, but it will increase filezilla responsibility alot.

comment:3 Changed 5 years ago by Tim Kosse

Resolution: fixed
Status: newclosed

This patch is no longer necessary, the engine now resides in its own thread. Fast transfers should no longer block the GUI.

Note: See TracTickets for help on using tickets.