Opened 7 years ago

Closed 4 years ago

#8185 closed Patch (outdated)

Add the ability to save and restore opened tabs

Reported by: Iliya Owned by: Rahul Nanwani
Priority: normal Component: FileZilla Client
Keywords: restore, tabs Cc:
Component version: Operating system type: Windows
Operating system version:

Description

Add the ability to save and restore opened tabs, and possibly modify command line argument "--site" so that it was possible to connect to multiple servers in a separate tabs.

Attachments (1)

update_patch (88.3 KB) - added by Rahul Nanwani 7 years ago.
update patch for save and restore tabs

Download all attachments as: .zip

Change History (15)

comment:1 Changed 7 years ago by Rahul Nanwani

Owner: set to Rahul Nanwani
Status: newaccepted

comment:2 Changed 7 years ago by Alexander Schuch

Only request one feature per feature request!

This feature request is ONLY about the ability to save/restore opened tabs. Using multiple "--site" parameters is covered by RFE #8179.

comment:3 Changed 7 years ago by Rahul Nanwani

Status: acceptedassigned

comment:4 Changed 7 years ago by Rahul Nanwani

The two features are completely different. I would be working on the ability to save and restore tabs.

comment:5 Changed 7 years ago by Iliya

Good, it is the main purpose of this ticket.

comment:6 in reply to:  5 Changed 7 years ago by Rahul Nanwani

What should be the ideal way to save the tab data? An XML file or like firefox does - a file in JSON format.
As of now, as a test, I stored in a text file but that obviously is a wrong way to do

comment:7 Changed 7 years ago by Iliya

It is more correct to keep opened tabs as is done with job queue - in SQL-Lite ...\config\queue.sqlite3
But, the last server instance is stored in XML format in the node <LastServer> in file \config\filezilla.xml
The text file is not a right way, you can take one of used methods of storage in FileZilla.

comment:8 Changed 7 years ago by Rahul Nanwani

Done with it.
Stores the tab data in an XML file.
Restores it (and prompts for password before connection in a new tab) and after restoring deletes the file.
I want to know how to submit the changes I have made. Please help.

comment:9 Changed 7 years ago by Iliya

Where you need to submit the changes you have made?

comment:10 Changed 7 years ago by Rahul Nanwani

yes.. i have made the changes on my local machine. where do i submit them?

comment:11 in reply to:  10 Changed 7 years ago by Alexander Schuch

Replying to rnanwani:

yes.. i have made the changes on my local machine. where do i submit them?

You create a patch using "diff -u", attach the patch to this tracker item, give instructions on how to apply this patch and turn this tracker item into type "patch".

Changed 7 years ago by Rahul Nanwani

Attachment: update_patch added

update patch for save and restore tabs

comment:12 Changed 7 years ago by Rahul Nanwani

Type: Feature requestPatch

i have attached the unified diff
patch using it in the /src directory

There should be 2 menu items for save and restore tabs.

comment:13 Changed 7 years ago by Tim Kosse

Status: assignedmoreinfo_assigned

Can you please reduce the patch to the relevant files? It contains the difference of many generated files. Best would be to just do svn diff.

comment:14 Changed 4 years ago by Tim Kosse

Resolution: outdated
Status: assignedclosed
Note: See TracTickets for help on using tickets.