Opened 7 years ago

Closed 2 years ago

#8176 closed Patch (outdated)

Patch: New file exist action, "owerwrite if newer else resume if sizes differ"

Reported by: Paolo Zambotti Owned by:
Priority: normal Component: FileZilla Client
Keywords: exist newer resume size Cc:
Component version: Operating system type: Windows
Operating system version: XP SP3

Description

Hello,

I find useful to have one more level of flexibility in the file exist action options: "overwrite if newer else resume if sizes differ".

I modified the source code (starting from svn rev. 4716) in that direction and I'm submitting the related patch for the convenience of all the other users.

Cheers,
Paolo.

Attachments (1)

OverwriteIfNewerElseResume.patch (8.8 KB) - added by Paolo Zambotti 7 years ago.
Overwrite if newer else resume if sizes differ patch file (from svn diff)

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Paolo Zambotti

Overwrite if newer else resume if sizes differ patch file (from svn diff)

comment:1 Changed 7 years ago by Tim Kosse

Status: newmoreinfo

Thanks, looking promising.

There are a couple of issues though that need to be addressed:

  • The new option needs to be added to the Default file exists action dialog, both in the settings and the stand-alone dialog.
  • The size-related checks in ControlSocket.cpp seem redundant.
  • The action says "Overwrite file if source file newer else resume" yet in some cases it skips. Should always try to resume instead of skipping in the else case.

comment:2 Changed 7 years ago by Paolo Zambotti

Thanks for your comments.

Well, even if I shortly call the action "Overwrite file if source file newer else resume" the best description coming from my original idea should be "Overwrite file if source file newer else resume if size differ". Basically my goal was to avoid the download/upload of unnecessary data. From my point of view, if the files have both a valid time (first check), that time is the same (second and third check) and the size is also the same (fifth check) then (the else condition) the files ARE exactly the same and there is no need to download/upload it again.

About your first point ("The new option needs to be added..."), I thought I already did that through the changes into settigns.xrc and dialoggs.xrc... I do not master so well the whole source code, could you be more specific, please?

comment:3 Changed 2 years ago by Kurt McKee

Resolution: outdated
Status: moreinfoclosed
Note: See TracTickets for help on using tickets.