Opened 15 years ago

Last modified 6 years ago

#806 closed Bug report

zlib missing in source FZ server

Reported by: hgfes Owned by:
Priority: normal Component: Other
Keywords: Cc: hgfes, Tim Kosse
Component version: Operating system type:
Operating system version:

Description

TransferSocket.h has this
#include <zlib.h>

zlib is not part of VC 7.1

After adding the missing zlib files to the zlib subdirectory
and changing to

#include "zlib\zlib.h"

there are still errors.

Microsoft Development Environment 2003 reports:
Linking...
LINK : warning LNK4098: defaultlib 'LIBC' conflicts with
use of other libs; use /NODEFAULTLIB:library
Accounts.obj : error LNK2019: unresolved external
symbol "bool cdecl IsValidAddressFilter(class
CStdStr<char> &,bool)" (?
IsValidAddressFilter@@YA_NAAV?$CStdStr@D@@_N@Z)
referenced in function "public: virtual unsigned char *
thiscall t_group::ParseBuffer(unsigned char *,int)" (?
ParseBuffer@t_group@@UAEPAEPAEH@Z)
Options.obj : error LNK2019: unresolved external
symbol "bool cdecl IsValidAddressFilter(class
CStdStr<char> &,bool)" (?
IsValidAddressFilter@@YA_NAAV?$CStdStr@D@@_N@Z)
referenced in function "public: void
thiscall
COptions::SetOption(int,char const *)" (?
SetOption@COptions@@QAEXHPBD@Z)
Permissions.obj : error LNK2019: unresolved external
symbol "bool cdecl IsValidAddressFilter(class
CStdStr<char> &,bool)" (?
IsValidAddressFilter@@YA_NAAV?$CStdStr@D@@_N@Z)
referenced in function "protected: void
thiscall
CPermissions::ReadSpeedLimits(class CMarkupSTL
*,class t_group &)" (?
ReadSpeedLimits@CPermissions@@IAEXPAVCMarkupSTL
@@AAVt_group@@@Z)
Accounts.obj : error LNK2019: unresolved external
symbol "bool cdecl MatchesFilter(class CStdStr<char>
const &,unsigned int,char const *)" (?
MatchesFilter@@YA_NABV?$CStdStr@D@@IPBD@Z)
referenced in function "public: bool
thiscall
t_group::AccessAllowed(struct sockaddr_in)const " (?
AccessAllowed@t_group@@QBE_NUsockaddr_in@@@Z)
ControlSocket.obj : error LNK2019: unresolved external
symbol "bool cdecl MatchesFilter(class CStdStr<char>
const &,unsigned int,char const *)" (?
MatchesFilter@@YA_NABV?$CStdStr@D@@IPBD@Z)
referenced in function "public: void
thiscall
CControlSocket::ParseCommand(void)" (?
ParseCommand@CControlSocket@@QAEXXZ)
ListenSocket.obj : error LNK2001: unresolved external
symbol "bool cdecl MatchesFilter(class CStdStr<char>
const &,unsigned int,char const *)" (?
MatchesFilter@@YA_NABV?$CStdStr@D@@IPBD@Z)
.\Debug/FileZilla server.exe : fatal error LNK1120: 2
unresolved externals

Change History (5)

comment:1 Changed 15 years ago by Tim Kosse

Please download and compile zlib. Third party libraries are
not distributed together with FileZilla.

comment:2 Changed 15 years ago by hgfes

Thanks codesquid, but your answer doesn't solve the problem. I
numbered unsolved problems to make it easier to distinguish
the issues.

The zlib include is wrong, non standard includes should use
quotes not less than and greater than symbols. (problem #1)

I have added zlib as I said and I tried to compile again. That
resulted in the errors listed. Something is wrong. (problem #2)

Where can I find a list of lib requirements? I don't even know
what version of zlib FZ requires. The manual should mention
these things but I can't find any mention in the package nor
on the site. (problem #3)

Thanks

comment:3 Changed 15 years ago by Tim Kosse

Please configure your build environment properly. (Add
proper include and library paths)

#include <zlib\zlib.h> is the correct include, since zlib is
not part of the FZ source.

comment:4 Changed 15 years ago by hgfes

codesquid, could you please address each problem separately?

Suggested corrections:
#1 Use '"' quotes not '<' or '>' in the FZ source
#2 The VC project file is wrong: conflicting libs specified
#3 Add lib requirements to documentation

comment:5 Changed 15 years ago by Tim Kosse

#1: <> is used for z-lib because it is an external library
and not in the FZ source.
#2: Make sure you compile the external libraries with the
correct runtime library settings (Multithreaded, statically
linked)
#3: ok, I should do that.

If you have further problems with your build environment,
please come to #filezilla on irc.freenode.net, this is not
the right place to discuss such things.

Note: See TracTickets for help on using tickets.