FileZilla Server 0.9.3 crash/hang

[mbobka]

Sometimes, when many clients connects/disconnets my
FileZilla Server hangs. I invistigate this problem, in
reality it not hangs, it crashes (and stops when
unhandled exception is processed in
CExceptionReport::UnhandledExceptionFilter(), because
this function wants user interaction, but FZS runs as
service, and it not have possibility to show message
boxes).
Also I found (as I think :) ) cause of exception.
Destructutor of CControlSocket object sends notification
FSM_CONNECTIONDATA with partially filled op->data
(filled only op->data->userid) other field filled with some
junk, but when this notification processed by
CServer::OnServerMessage() more than one field of op-

data is required (e.g. op->data->ip).

For resolve problem I make following patch in file
Server.cpp (search attached file for PATCH HERE text).

[mbobka]

Patched Server.cpp

[Tim Kosse]

Thanks for reporting this issue.

Unfortunately your patch would increase CPU usage slightly,
which is unneccessary.

I've modified the code so that only the neccessary members
of op get used: For example the ip only gets used on
USERCONTROL_CONNOP_ADD notifications now.

Now some CPU cycles are even saved and also some bandwidth
for the admin connection compared to the original code.

I've committed the changes to the CVS repository, they
should be available soon.