Fix issues reported by code analyzer

[eyebex]

Fix a few (possible) issues identified by the Visual Studio 2008 static code analyzer in the FZS Interface. Most issues are caused by uninitialized variables for certain (unlikely / presumably never to be taken) program flows, data type mismatches or hiding variables from outer scopes.

[Tim Kosse]

Applied with some minor changes.

I wonder, did you actually test this? Because it failed to compile since CStdString has no GetString() method. Using cast to LPCTSTR instead.

[eyebex]

That's odd, it compiles fine here. Maybe my SP1 for VS2008 makes a difference?

[eyebex]

Another comment: I believe using NULL instead of 0 for pointers is better style, because it makes it easier to see that it's a pointer you're dealing with. Moreover, the next C++ standard will introduce the nullptr keyword for pointers. If NULL is used in old code, that makes migration a lot easier.

[Tim Kosse]

Matter of style. I prefer 0, way faster.