Opened 10 years ago

Closed 10 years ago

#4751 closed Bug report (fixed)

use --binary option to create checksum files, as with text mode they fail on Windows

Reported by: maddes_b Owned by:
Priority: high Component: Other
Keywords: Cc:
Component version: Operating system type: Windows
Operating system version: XP PS3

Description

SHASUM defaults to text mode on Linux, but as Filezilla downloads are binaries the option "--binary" should be used.
Binary checksums are marked with a star.
This avoids problems on other platforms, e.g. Windows, with different EOL settings (text mode).

GNU shasum taken from http://gnuwin32.sourceforge.net/packages/coreutils.htm

Example:

Microsoft Windows XP [Version 5.1.2600]
(C) Copyright 1985-2001 Microsoft Corp.

E:\shasum>dir
 Volume in drive E is DATA2
 Volume Serial Number is 005D-C607

 Directory of E:\shasum

16.08.2009  15:48    <DIR>          .
16.08.2009  15:48    <DIR>          ..
16.08.2009  15:46               318 FileZilla_3.2.7.sha512.fail
16.08.2009  15:47               318 FileZilla_3.2.7.sha512.work
15.08.2009  17:37         6.034.017 FileZilla_3.2.7_win32.zip
15.08.2009  17:37         4.077.360 FileZilla_3.2.7_win32-setup.exe
               4 File(s)     10.112.013 bytes
               2 Dir(s)  149.570.146.304 bytes free

E:\shasum>type FileZilla_3.2.7.sha512.fail
651dcdf54aa716ccb4b418f70bab2866c786aee1b95ac42a3aec8bd7838bbd863d18de094fc5e1aa2940ed2b8d00bbbd767a1d57c12ba7003c39f7052ef98433  FileZilla_3.2.7_win32-setup.ex
e
7b89c98608566dc49d9537b6ba6be554b47299338ced5bd132ab0d82755ab61eeb059d78c8621c377609186516252ad3a53bc2f28f8ab6192b04ecbb61f84cc5  FileZilla_3.2.7_win32.zip

E:\shasum>shasum -a 512 --check FileZilla_3.2.7.sha512.fail
FileZilla_3.2.7_win32-setup.exe: FAILED
FileZilla_3.2.7_win32.zip: FAILED
shasum: WARNING: 2 of 2 computed checksums did NOT match

E:\shasum>type FileZilla_3.2.7.sha512.work
651dcdf54aa716ccb4b418f70bab2866c786aee1b95ac42a3aec8bd7838bbd863d18de094fc5e1aa2940ed2b8d00bbbd767a1d57c12ba7003c39f7052ef98433 *FileZilla_3.2.7_win32-setup.ex
e
7b89c98608566dc49d9537b6ba6be554b47299338ced5bd132ab0d82755ab61eeb059d78c8621c377609186516252ad3a53bc2f28f8ab6192b04ecbb61f84cc5 *FileZilla_3.2.7_win32.zip

E:\shasum>shasum -a 512 --check FileZilla_3.2.7.sha512.work
FileZilla_3.2.7_win32-setup.exe: OK
FileZilla_3.2.7_win32.zip: OK

E:\shasum>

Change History (1)

comment:1 Changed 10 years ago by Tim Kosse

Resolution: fixed
Status: newclosed

Build scripts have been adjusted.

Note: See TracTickets for help on using tickets.