#4430 closed Patch (rejected)
Patch to bug ticket 4199
Reported by: | cs419hewe | Owned by: | |
---|---|---|---|
Priority: | low | Component: | FileZilla Client |
Keywords: | seo | Cc: | |
Component version: | Operating system type: | Windows | |
Operating system version: |
Description
I would like to propose a patch for a bug ticket 4199. The bug was the value of maxMultiple was set to not 0 upon checkbox of enabling limit number simultaneous connections. The patch follows the default action of the UI of setting maxMultiple to 1 upon the checkbox for enabling simultaneous connections.
I've attached a diff file of the changes.
Attachments (1)
Change History (3)
by , 16 years ago
Attachment: | sitemanager.diff added |
---|
comment:1 by , 16 years ago
Resolution: | → rejected |
---|---|
Status: | new → closed |
comment:2 by , 13 years ago
You made a mistake on the fouth line regarding SetValue(maxMultiple = 1).
maxMultiple = 1 will walways return true !
Instead of = you want to use ==, which will evaluate against maxMultiple.
Like this:
SetValue(maxMultiple == 1)
/Aktiviteter.
1673 1673 XRCCTRL(*this, "ID_TRANSFERMODE_DEFAULT", wxWindow)->Enable(!predefined);
1674 1674
1675 1675 int maxMultiple = site_data->m_server.MaximumMultipleConnections();
1676 XRCCTRL(*this, "ID_LIMITMULTIPLE", wxCheckBox)->SetValue(maxMultiple != 0);
1676 XRCCTRL(*this, "ID_LIMITMULTIPLE", wxCheckBox)->SetValue(maxMultiple = 1);
1677 1677 XRCCTRL(*this, "ID_LIMITMULTIPLE", wxWindow)->Enable(!predefined);
1678 1678 if (maxMultiple != 0)
1679 1679 {
I would like to propose a patch for a bug ticket 4199. The bug was the value of maxMultiple was set to not 0 upon checkbox of enabling limit number simultaneous connections. The aktiviteter århus patch follows the default action of the UI of setting maxMultiple to 1 upon the checkbox for enabling simultaneous connections.
I've attached a diff file of the changes.
The attached patch is not correct. It always sets the limit to one regardless of the previous value.
What exactly are you trying to solve with your patch? It's not clear from your description.