Unable to download/delete a directory if all its contents are filtered

[sNop]

Hi,

I know about this bug very long time and I have still hoped that this bug will be fixed in new a release but I have mistaken. :)

So where is the problem ? I will write how reproduce the bug.

Create direcory e.g. test/ and in this direcory create directory .svn/ (or file .svn), turn on "Directory listing filters" and create filter which will filter .svn direcory(or file) and try upload this direcory. Filezilla doesn't upload this directory.

It works with any number of filtered items. But if directory contain some or only one unfiltered dir or file, then the directory will be uploaded.

It affects downloading as well and when You try delete that directory with filtered dir or files on FTP!, Filezilla doesn't delete that folder.

[Tim Kosse]

Care to explain why you flagged this as critical? This is not a security related bug that can be exploited and also does not result in data loss.

[sNop]

Replying to codesquid:

Care to explain why you flagged this as critical? This is not a security related bug that can be exploited and also does not result in data loss.

sry, You are right and I don't know what exactly that means, but is critical for me :)
Again I'm sorry.

[sNop]

I would like to ask, if You can repair this bug, because Filezilla is unusable for me. I can't use filters, because if I use it, I can't rely on its functionality.

And isn't in my power inspect if every direcotry was uploaded.

Thank You

[Tim Kosse]

Deleting a directory with files filtered out is working as intended.

The uploading issue should be fixed, can you please try the most recent version?

[sNop]

Hi,

so upload works and delete dirs on local site as well.

But download doesn't, the same when I have set up filter for .svn/ dirs and I create dir e.g. test/ on FTP ( remote site ) and in this dir I create .svn/ dir, so I can't download dir test/ and the same with deletion of the dir test/.

The issue is opened very long time and have big impact to the FileZilla's functionality.

Thank you for fix.

[User1235]

Replying to snop:

Hi,

I know about this bug very long time and I have still hoped that this bug will be fixed in new a release but I have mistaken. :)

So where is the problem ? I will write how reproduce the bug.

Create direcory e.g. test/ and in this direcory create directory .svn/ (or file .svn), turn on "Directory listing filters" and create filter which will filter .svn direcory(or file) and try upload this direcory. Filezilla doesn't upload this directory.

It works with any number of filtered items. But if directory contain some or only one unfiltered dir or file, then the directory will be uploaded.

It affects downloading as well and when You try delete that directory with filtered dir or files on FTP!, Filezilla doesn't delete that folder.

[User1235]

PATCH!

[Luke]

I also cannot download an empty directory. Is there a flag I have to change somewhere to allow empty directories to be downloaded locally? It's a real pain to go through the entire website directory and check/create/re-create all the directories that weren't transferred... Thanks :)

[Alexander Schuch]

This bug report is about the inability to download an empty directory if it only contains filtered items (via directory listing filter) or about deleting it.

The steps to re-produce the problem are given in a comment by snop and they still apply to FileZilla 3.7.1.1.

[Kurt McKee]

I have tested this with FileZilla Client 3.26.1 (Windows 7). Here are the results.

tl;dr -- Downloading a remote directory that is actually empty works. Downloading a remote directory that is empty because its contents are filtered does not work. But it appears that filtering is working as expected.

The setup uses a local site directory (I've named it local/ in the examples below) with this directory structure:

/
`-- local/
    `-- .svn/

I have not created any directories on the remote site root directory (I've named it remote/ in the examples below).

Uploading to the server

1. Enable the local site filter named "Source control directories".
2. Drag and drop the local/ directory from the local site to the remote site.
3. The remote site will now contain this directory structure:

/
`-- local/

Note that the .svn/ directory was not uploaded.

Downloading from the server (filters off)

1. Rename the local/ directory on the remote site. Change its name to remote/.
2. Disable the local site filter named "Source control directories".
3. Drag and drop the remote/ directory from the remote site to the local site.
4. The empty remote/ directory will be copied to the local site.

Downloading from the server (filters on)

1. Delete the remote/ directory on the local site.
2. Enter the remote/ directory on the remote site and create a directory named .svn/.
3. Enable the remote site filter named "Source control directories".
4. Confirm that the .svn/ directory on the remote site is no longer visible.
5. Navigate to the root of the remote site.
6. Drag and drop the remote/ directory from the remote site to the local site.
7. The remote/ directory will not be copied to the local site.

Deleting from the server (filters on)

1. Attempt to delete the remote/ directory on the remote site.
2. The remote/ directory will fail to delete because it is not empty.

Conclusion

It appears that the filtering is working as expected. However, it may be a bug that there is a difference in behavior when copying a remote directory that is actually empty versus a remote directory that is empty because all of its contents are filtered.

However, it is probably not a bug that FileZilla will not delete a directory containing filtered files and directories.