Possible problem with sitemanager.xml syntax

[eyebex]

I just created a new dummy site after a fresh installation of FZ3. This is what the sitemanager.xml look like:

<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<FileZilla3>

<Servers>

<Folder>New folder

<Server>

<Host>sdr</Host>
<Port>34</Port>
<Protocol>0</Protocol>
<Type>0</Type>
<Logontype>0</Logontype>
<TimezoneOffset>0</TimezoneOffset>
<PasvMode>MODE_DEFAULT</PasvMode>
<MaximumMultipleConnections>0</MaximumMultipleConnections>
<EncodingType>Auto</EncodingType>
<Comments></Comments>
<LocalDir></LocalDir>
<RemoteDir></RemoteDir>New site

</Server>

</Folder>

</Servers>

</FileZilla3>

As you can see, the site's name "New site" is not stored inside any tag, but loosely inside its parent "Server" tag. I'm not sure if this is valid XML. At least it would be nice to introduce a "Name" tag to encapsulate the site's name.

The same holds true for a folder's name ("New folder" in the example above).

[eyebex]

Or maybe even better: Make the name of a site / folder an attribute (instead of a sub-tag) of the parent tag (i.e. the "Folder" or "Server" tag).

[Tim Kosse]

It's valid XML.

Changing it now that FZ3 is released would just make the code more complex and would just be confusing.