Server: TransferSocket::OnSend missing a byte

[mrdoubleyou]

in case numsent < numread, the remainder of the buffer
is copied to the beginning of the buffer. However, the
code as it is, will miss one byte, due to the incorrect +1.
This causes corrupt files on the receiving client.
Isn't it possible to use memcpy? or is this a problem as
the two ranges overlap?

else if (numsent<numread)
{ This should not happen, but handle it in case it
happens

why shouldn't this happen? send() is not garantueed

to send the specified

number of bytes, so this might very well happen, as

it most certainly

does on the XBOX
for (int i=0;i<(numread-numsent);i++)
{

m_pBuffer[i]=m_pBuffer[i+numsent+1];
m_pBuffer[i]=m_pBuffer[i+numsent];

}

m_nBufferPos=numread-numsent;

}

[mrdoubleyou]

instead of the for-loop, this also works and might be faster:
memmove(m_pBuffer, m_pBuffer + numsent, numread -
numsent);

[Tim Kosse]

Thanks for reporting this bug.

The strange thing is, that numsent<numread did NEVER
happen during all my tests.
I've transferred hundreds of gigs back and forth during the last
big test on several machines, but all files were transferred
without corruption which means that numsent<numread did
never happen.