Opened 12 years ago

Last modified 12 years ago

#1527 closed Patch

Pointer comparison using < and > is gcc-specific

Reported by: rklrkl Owned by:
Priority: normal Component: FileZilla Client
Keywords: Cc: rklrkl, Tim Kosse
Component version: Operating system type:
Operating system version:

Description

In the source file src/putty/timing.c in FileZilla 3.0.4 (apologies here that I haven't got the CVS version...), there is code specific to only lcc around line 44 onwards. In fact, it's likely to apply to all non-gcc compilers, because pointer comparison using "<" and ">" operators appears to be a gcc-specific extension.

Hence, this patch simply widens the lcc check to include all non-gcc compilers instead. By doing this, it allows the source file to compile using HP's ANSI C compiler on HP-UX 11. There could be an argument to actually ditch the gcc-only version too and use the generic one, but that's up to you...

Attachments (1)

timing.c.patch (526 bytes) - added by rklrkl 12 years ago.
Patch for src/putty/timing.c to allow compilation with non-gcc compilers

Download all attachments as: .zip

Change History (2)

Changed 12 years ago by rklrkl

Attachment: timing.c.patch added

Patch for src/putty/timing.c to allow compilation with non-gcc compilers

comment:1 Changed 12 years ago by Tim Kosse

Thanks, your patch has been applied.

Note: See TracTickets for help on using tickets.