Opened 13 years ago

Closed 6 years ago

Last modified 6 years ago

#1508 closed Patch (fixed)

let FZ3 create empty directory also

Reported by: tommywu Owned by:
Priority: normal Component: FileZilla Client
Keywords: Cc: tommywu, Tim Kosse, lfrohling01@…
Component version: Operating system type:
Operating system version:

Description

When we try to transfer whole directory, empty
directory won't be created in FZ3.
This patch will let FZ3 create directory even it is empty.

Attachments (1)

filezilla3_beta2_transfer_empty_dir.patch (4.0 KB) - added by tommywu 13 years ago.
let FZ3 create empty directory also

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by tommywu

let FZ3 create empty directory also

comment:1 Changed 13 years ago by Tim Kosse

Thanks, though unfortunately I cannot apply this fix in its
current form.

Creation of empty local directories should be done within
the interface itself, the engine should not be invoked for it.
Empty remote directories should be done by using
CMkdirCommand, using CFileTransferCommand is an ugly hack.
Furthermore, if using file transfers for local directory
creation, all code which displays the status, i.e. log
message, queue pane and so on would have to be updated to
reflect that it's a directory creation.

I did update CRemoteListView to directly create empty
directories if they get enumerated during recursive operations.

comment:2 Changed 13 years ago by tommywu

Yes, I know that's an ugly solution.

But, I think put this to transfer command will better than
put it in interface. For recursive transfer directory,
create directory and create file should be consider a same
session.

For create local empty directroy, yes, your solution in
RemoteListView will also create empty directory, but, the
directory is not created during download, they're created
during list the directory. If someone just add a remote
directory the queue, the empty directory will be created
already, before really start the transfer session. It would
be very strange if someone just add to queue, and delete
from queue, the directory already created.

For create remote directory... because we need to send
commnad to remote site, I don't think put this to interface
only (LocalListView) can provide this function.

Anyway, I think, consider create empty directory in trasnfer
session will be better than do it in interface only.

Maybe, add another field in entry structure, to identify it
just for create directory, as I add '\' or '/' in local
filename as a directory.

comment:3 Changed 13 years ago by Tim Kosse

I've commited some changed to add a new QueueItemType_Folder
itemtype for the queue. Old one has been renamed to
QueueItemType_FolderScan. Implementation is not complete yet
though.

comment:4 Changed 6 years ago by Luke

Cc: lfrohling01@… added
Operating system type: OS X
Operating system version: OS X
Status: closedreopened

I also cannot download an empty directory. Is there a flag I have to change somewhere to allow empty directories to be downloaded locally? It's a real pain to go through the entire website directory and check/create/re-create all the directories that weren't transferred... Thanks :)

comment:5 Changed 6 years ago by Alexander Schuch

Operating system type: OS X
Operating system version: OS X
Resolution: fixed
Status: reopenedclosed

@lfrohling: Please refrain from spamming your issue all over. Please create a NEW bug report, and provide logs.

Note: See TracTickets for help on using tickets.