Opened 14 years ago

Last modified 5 years ago

#1482 closed Patch

Toggle MODE Z in FEAT response

Reported by: eyebex Owned by:
Priority: normal Component: FileZilla Server
Keywords: Cc: eyebex, Tim Kosse
Component version: Operating system type:
Operating system version:

Description

This patch disables listing MODE Z in response to a
FEAT command if Zip compression has been disabled in
the server settings. The patch consists of two parts:
The first file just trims all trailing spaces in the
file to be patched, the second applies the patch.

Attachments (1)

ModeZFeatPatch.zip (5.1 KB) - added by eyebex 14 years ago.
Zipped two-part patch of ControlSocket.cpp

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by eyebex

Attachment: ModeZFeatPatch.zip added

Zipped two-part patch of ControlSocket.cpp

comment:1 Changed 14 years ago by Tim Kosse

Thanks. I had to modify your patch though, with your patch
applied, FEAT response did miss the final part if MODE Z was
disabled. Please test your changes more thorough.

comment:2 Changed 14 years ago by eyebex

Are you sure the patch made it into the 0.9.8c release as
announced? For me, 0.9.8c still lists MODE Z in the FEAT
response if MODE Z is disabled from the settings.

comment:3 Changed 14 years ago by Tim Kosse

That happens when I use copy&paste to fix a patch, I carry
over the original errors.
You were using GetOption instead of GetOptionVal

comment:4 Changed 14 years ago by eyebex

Yes, sorry for that, I had fixed the typo locally but the
patch still contained the first version. This also sort of
explains why you claimed my patch would not work and why you
used two nested if statements instead of "&&". With
GetOptionVal, the "&&" construct should work, though.

Note: See TracTickets for help on using tickets.