Opened 14 years ago

Last modified 14 years ago

#1475 closed Patch

New cmdline args so it doesn't hang

Reported by: elsapo Owned by:
Priority: normal Component: Other
Keywords: Cc: elsapo, Tim Kosse
Component version: Operating system type:
Operating system version:

Description

Added three new command line arguments:

-close

close main dialog (as soon as transfer completes)

-noclose

do not close main dialog (default)

  • overwrite overwrite existing files without prompt

The "-close" is so commandline invocation doesn't leave
filezilla.exe running forever, especially if run from a
batch file not in the interactive desktop (where noone
will ever see it).

The "-noclose" is just something you can add to the end
of a command line when debugging, to cancel an earlier
"-close" on the command line (or getting added
elsewhere by a variable).

The "-overwrite" is to avoid the dialog hanging at the
prompt for overwrite/nooverwrite -- this avoids having
to set a choice in the user profile which would lock in
the user and every script invocation run under that
user account -- that is, this allows making the choice
relevant for the particular command line invocation.

Attachments (1)

filezilla_cmdline_close.zip (56.0 KB) - added by elsapo 14 years ago.
56Kb zip of the original & modified MainFrm.cpp

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by elsapo

Attachment: filezilla_cmdline_close.zip added

56Kb zip of the original & modified MainFrm.cpp

comment:1 Changed 14 years ago by elsapo

I've attached my original & modified MainFrm.cpp, so you can
either diff them visually, or generate a patch with whatever
context settings you like. Let me know if you would like
another format instead.

comment:2 Changed 14 years ago by elsapo

Go here

http://www.geocities.com/fzperry/1193050/patch_1193050.htm

for a binary exe version (along with source).

(Its too large to upload here.)

comment:3 Changed 14 years ago by elsapo

I'm not sure that IsQueueEmpty is the right method for my
test (when it is ok to close the dialog).

I really need to know if there are any active items left in
the queue, discounting any errors hanging out in the list
view (which is what IsQueueEmpty looks at).

comment:4 Changed 14 years ago by Tim Kosse

Thanks, your patch has been applied.

A fixed version will be available in the next few days.

Note: See TracTickets for help on using tickets.