Incorrect error message "Invalid username given" when invalid host entered in Site Manager

[aheck]

When entering a site in Site Manager, if an invalid Host is provided, when attempting to click Connect or OK, the error message says "Invalid username given". To be clear, the error checking is fine, it is the error message that is incorrect.

Steps to reproduce:

• Open site manager
• Add new site
• Enter in any User
• Enter in any Password
• Enter a Host name - include a @ at the *start* of your Host name
• Click OK or Connect

Platform: Windows x64

[Discovered when being a lazy copy/paster]

[aheck]

Screenshot

[Tim Kosse]

Intended behavior.

Hostnames cannot contain @ character.

[aheck]

This ticket was closed but the point was missed. It's not that hostnames cannot have an @ in their name, it's that when a hostname is invalid, the error message should state "Invalid hostname given". Instead the error message reads "Invalid username given".

[Tim Kosse]

Everything before the @ is a username, usernames cannot empty, hence the message about the invalid username.