Opened 12 years ago

Last modified 12 years ago

#1296 closed Bug report

Assumption of coding error in CAsyncSocketEx

Reported by: pimpoutte Owned by:
Priority: normal Component: FileZilla Client
Keywords: Cc: pimpoutte, Tim Kosse
Component version: Operating system type:
Operating system version:

Description

In CAsyncSocketExHelperWindow::RemoveLayers(...)

Line 274 :

if (!pMsg
!pSocket pSocket == pOrigSocket pSocket->m_SocketData.hSocket != pMsg->hSocket)

Should be :

if (!pMsg
!pSocket pSocket == pOrigSocket pSocket->m_SocketData.hSocket == pMsg->hSocket)

Change History (2)

comment:1 Changed 12 years ago by Tim Kosse

No, that line is correct. It filters out all messages belonging either to the same instance (pSocket == pOrigSocket) or all messages with an unmatched handle (pSocket->m_SocketData.hSocket != pMsg->hSocket)

comment:2 Changed 12 years ago by pimpoutte

OK, thanks for the explanation

Note: See TracTickets for help on using tickets.