Opened 18 years ago
Last modified 18 years ago
#1262 closed Bug report
PORT Command Octal IP
| Reported by: | matrix-ntn | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | FileZilla Server |
| Keywords: | Cc: | matrix-ntn, Tim Kosse | |
| Component version: | Operating system type: | ||
| Operating system version: |
Description
Hello,
i have posted a Feature Requst (1714025)...
After looking trough the Sourcecode i found following:
ControllSocket.cpp
#ifdef _UNICODE
int res = inet_addr(ConvToLocal(ip));
#else
int res = inet_addr(ip);
#endif
if (res == INADDR_NONE)
When the IP is octal then res are not INADDR_NONE.
I mean this is a bug...
Greetings
Tobias
Change History (2)
comment:1 by , 18 years ago
comment:2 by , 18 years ago
Some broken clients use octal notation, some other broken clients use prefix the addresses with 0. Both are broken and need to be fixed, so not a problem with FileZilla Server.
Note:
See TracTickets
for help on using tickets.
In the FTP RFC are following lines:
"DATA PORT (PORT)
....
This address information is broken into 8-bit fields and the
value of each field is transmitted as a decimal number (in
character string representation)"
Source:http://www.faqs.org/rfcs/rfc959.html
The Function inet_addr() doesent return an error at a octal ip.
(http://support.microsoft.com/kb/115388)
Filezilla must(!) stripes the leading Zeors and interpret the ip always as decimal and never as octal!!!!
Please Fix that bug.
Thanks