Opened 4 months ago

Closed 4 months ago

#11930 closed Bug report (fixed)

missing --tag=CXX when compiling filezilla

Reported by: Thomas Klausner Owned by:
Priority: normal Component: FileZilla Client
Keywords: Cc:
Component version: 3.42.1 Operating system type: BSD
Operating system version: NetBSD 8.99.38

Description

In the generated file src/interface/Makefile.in, there is not "--tag=CXX" argument in the filezilla_LINK variable, which makes linking fail in my environment because libtool complains about the missing tag.

I see that there are tries to add it in the corresponding Makefile.am but it's perhaps in the wrong variable?
Anyway, I need the attached patch to compile filezilla.

Change History (2)

comment:1 Changed 4 months ago by Thomas Klausner

Ok, I failed at uploading the patch, so here is it inline.

--- src/interface/Makefile.in.orig      2019-05-08 16:34:47.000000000 +0000
+++ src/interface/Makefile.in
@@ -310,7 +310,7 @@ am__v_lt_ = $(am__v_lt_@AM_DEFAULT_V@)
 am__v_lt_0 = --silent
 am__v_lt_1 = 
 filezilla_LINK = $(LIBTOOL) $(AM_V_lt) $(filezilla_LIBTOOLFLAGS) \
-       $(LIBTOOLFLAGS) --mode=link $(OBJCXXLD) \
+       $(LIBTOOLFLAGS) --mode=link --tag=CXX $(OBJCXXLD) \
        $(filezilla_OBJCXXFLAGS) $(OBJCXXFLAGS) $(filezilla_LDFLAGS) \
        $(LDFLAGS) -o $@
 AM_V_P = $(am__v_P_@AM_V@)

comment:2 Changed 4 months ago by Tim Kosse

Resolution: fixed
Status: newclosed

Note that Makefile.in is an auto-generated file, an actual fix requires changing Makefile.am

This should be fixed in the latest revision in the repository.

Note: See TracTickets for help on using tickets.