Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#11478 closed Patch (rejected)

[PATCH] Use reverse-DNS style AppStream ID

Reported by: Nate Graham Owned by:
Priority: normal Component: FileZilla Client
Keywords: Cc:
Component version: Operating system type: Linux
Operating system version:

Description

AppStream IDs are required to use the reverse-DNS style, e.g. "org.filezilla-project.Filezilla". I'm attaching a patch that accomplishes that.

Relevant section of the AppStream spec: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent


On a practical note, having a non-rDNS-style AppStream ID is problematic for users of GNOME Software and KDE Discover (and other similar software center apps) when Filezilla is available from their distros' packages as well as Flathub--which correctly enforces rDNS-style AppStream IDs. If the AppStream IDs don't match between these sources, then the software centers can't de-duplicate them and users confusingly see two entries when they search for FileZilla. Standardizing on the rDNS-style ID eliminates this problem (in addition to conforming to the spec).

Attachments (1)

appstream-id-rdns.patch (639 bytes) - added by Nate Graham 2 years ago.
Patch to use reverse-DNS-style AppStream ID

Download all attachments as: .zip

Change History (8)

Changed 2 years ago by Nate Graham

Attachment: appstream-id-rdns.patch added

Patch to use reverse-DNS-style AppStream ID

comment:1 Changed 2 years ago by Tim Kosse

Resolution: fixed
Status: newclosed

Thanks, applied.

comment:2 Changed 2 years ago by Nate Graham

Resolution: fixed
Status: closedreopened

Oh, so close! I see you applied it as org.filezilla-project.FileZilla. I'm afraid Flatpak doesn't permit dashes anywhere but the last token of the URL, so it has to be org.filezillaproject.FileZilla. For more info, see https://github.com/flathub/org.filezillaproject.Filezilla/pull/1

comment:3 Changed 2 years ago by Tim Kosse

Resolution: rejected
Status: reopenedclosed

This is a bug in Flatpak then. org.filezilla-project.FileZilla is a valid reverse DNS name.

The human-readble description aside, according to appstream.xsd the id does not even have to be a reverse DNS syle name, applications making use of appstream should be able to handle arbitrary strings, or alternatively the .xsd needs to be fixed to _properly_ specify the syntax for the id element.

comment:4 Changed 2 years ago by Nate Graham

OK fair enough. I'll start a conversation with the Flatpak and Flathub people about it. You can follow along in https://github.com/flathub/org.filezillaproject.Filezilla/pull/1

comment:5 Changed 2 years ago by Nate Graham

Apparently the full rDNS style is not totally supported, it's just "rDNS-like". The Flatpak folks say you'll have to remove the dash.

Sorry for the bad new, but I'm just the messenger!

comment:6 Changed 2 years ago by Tim Kosse

Do you have a statement from the Appstream specification makers supporting this?

comment:7 Changed 2 years ago by Nate Graham

OK, I learned something here. The discussion is in https://github.com/flathub/org.filezillaproject.Filezilla/pull/1#issuecomment-354509330.

This seems to be the long and short of it:

Given that these should match but the spec for one is stricter than another, I've recommended to the AppStream developers that they adopt the DBus style to avoid further confusion of this sort: https://github.com/ximion/appstream/issues/162

Sorry for all this hassle! I thought this would be a nice simple patch...

Note: See TracTickets for help on using tickets.