Opened 2 years ago

Closed 2 years ago

#10829 closed Patch (fixed)

[new feature] Option to copy URL with password

Reported by: Julien Blitte Owned by:
Priority: normal Component: FileZilla Client
Keywords: client URL CServer FormatServer Cc:
Component version: 7473 Operating system type:
Operating system version:

Description

Hi,
This patch is a modification proposal to add the option to include the password when copying an URL (mainly for FTP protocol).

The option has to be enabled by user, and before activation a security warning is of course shown.

I know this option can be seen as unsafe but, I really need it: I am dealing with 4-5 different FTPs all the day and I have to add password back manually each time I want to send a FTP link to one of my customer.

Modification are made on top of revision 7470.
Main modification is the method FormatServer of CServer.

Warning: I am sorry but I did this patch without compiling and testing it, so next steps would be try to compile with it and to debug it.

If feature is approved, it should not be hard to debug it anyway, I am not bad in C/C++ but there will be obviously some bugs/typo as just added some piece of code with notepad in few files.

Julien

Attachments (3)

Option to copy URL with password.patch (18.9 KB) - added by Julien Blitte 2 years ago.
Patch - Option to copy URL with password
Option to copy URL with password_2.patch (23.3 KB) - added by Julien Blitte 2 years ago.
Patch - Option to copy URL with password (compiles)
Option to copy URL with password_3.patch (22.0 KB) - added by Julien Blitte 2 years ago.
Patch - Option to copy URL with password (compiles, full works and run without error)

Download all attachments as: .zip

Change History (9)

Changed 2 years ago by Julien Blitte

Patch - Option to copy URL with password

comment:1 Changed 2 years ago by Tim Kosse

Status: newmoreinfo

Please fix the patch such that the result compiles.

Changed 2 years ago by Julien Blitte

Patch - Option to copy URL with password (compiles)

comment:2 in reply to:  1 Changed 2 years ago by Julien Blitte

Status: moreinfonew

Replying to codesquid:

Please fix the patch such that the result compiles.

Done. I make a clean version that compiles and almost* works.

Patch is upon version 7473 now.

*Sorry, I have one an WX issue remaining at execution (located in src/interface/Mainfrm.cpp:840 - when I try to untick the menu), I did not manage to fix it yet.

The rest seems to work. I upload another version without the error.

Changed 2 years ago by Julien Blitte

Patch - Option to copy URL with password (compiles, full works and run without error)

comment:3 Changed 2 years ago by Julien Blitte

Component version: 74707473

comment:4 Changed 2 years ago by Julien Blitte

comment:5 Changed 2 years ago by Tim Kosse

I've committed some of the changes from your patch with a few modifications:

  • Dropped the superfluous extra #includes
  • Renamed the new enum and made it a strongly-typed one

So far I haven't decided what to do about the GUI portion. An extra item in the main menu just to toggle passwords in a contextual feature feels like really bad UI design.

I need to do something about the URL encoding as well.

comment:6 Changed 2 years ago by Julien Blitte

Resolution: fixed
Status: newclosed

Patch integrated with the great enhancements from Tim.
Thanks !

New functionality: Starting 3.18.0 RC, pressing [Shift] while doing a right click will enable option to copy with password.

Internal code changes : CServer / FormatServer and URL encoding also done by Tim as far as I saw in the code.

Julien Blitte

Note: See TracTickets for help on using tickets.