Opened 4 years ago

Last modified 4 years ago

#10656 moreinfo_accepted Patch

bookmark category

Reported by: ali77 Owned by: Stephen L'Allier
Priority: normal Component: FileZilla Client
Keywords: Cc:
Component version: Operating system type: Windows
Operating system version:

Description

i have many (for example 100) bookmarks in FileZilla for my site.
it is undesirable for me to work with a confused bookmark list :|

i suggest you to add categorize feature to bookmark part of Filezilla.

Attachments (2)

bookmarks_dialog_diff.txt (11.2 KB) - added by Stephen L'Allier 4 years ago.
bookmarks_dialog_h_diff.txt (1.7 KB) - added by Stephen L'Allier 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by Stephen L'Allier

Owner: set to Stephen L'Allier
Status: newaccepted

comment:2 Changed 4 years ago by Stephen L'Allier

Type: Feature requestPatch

Changing status from feature request to patch. Unified context diff will be attached.

Last edited 4 years ago by Stephen L'Allier (previous) (diff)

Changed 4 years ago by Stephen L'Allier

Attachment: bookmarks_dialog_diff.txt added

Changed 4 years ago by Stephen L'Allier

Attachment: bookmarks_dialog_h_diff.txt added

comment:3 Changed 4 years ago by Stephen L'Allier

This feature request was worked on as a group project at Florida Institute of Technology for an Intro to Software Engineering class. The group members were: Ash Clarke, Stephen L'Allier, Yannis Lewis, and Trung Nguyen. Yannis primarily worked on this feature request.

comment:4 Changed 4 years ago by Tim Kosse

There are a bunch of issues with the patch:

  • Memory leaks
  • Missing nullpointer checks
  • Hardcoded menu ids
  • A using directive
  • not passing parameters as constref where possible
  • the code operates on site-specific bookmarks. Where are the corresponding changes to the Site Manager?

Please fix these.

comment:5 Changed 4 years ago by Tim Kosse

Status: acceptedmoreinfo_accepted
Note: See TracTickets for help on using tickets.