Opened 9 years ago

Last modified 8 years ago

#10345 moreinfo_accepted Patch

Scrolling with drag and drop scrolls too fast, too far

Reported by: Shawn LaMaster Owned by: Stephen L'Allier
Priority: normal Component: FileZilla Client
Keywords: scrollig with drag and drop Cc:
Component version: Operating system type: Windows
Operating system version:


With the latest version I have 3.10.2, now there is automatic scrolling of folders with drag and drop but if the window is not huge, it is almost impossible to actually select your target! It keeps scrolling away. I think this is from the fix for ticket #132. It did not use to scroll at all, which I understand is a problem, but now it scrolls too much. I use this everyday and think it is great, but now it is much more difficult. I've been writing code for over 20 years.

Attachments (1)

drop_target_ex_diff.txt (888 bytes ) - added by Stephen L'Allier 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by Tim Kosse, 9 years ago

Status: newmoreinfo
Summary: Fix for ticket #132 - scrolling with drag and drop scrolls too fast, too farScrolling with drag and drop scrolls too fast, too far

Unrelated to ticket #132, that one's actually for an ancient and discontinued version of FileZilla.

How large exactly is "not huge"?

comment:2 by Shawn LaMaster, 9 years ago

Status: moreinfonew

It seems like the target window has to be at least 8 to 10 lines to allow a folder to not just scroll right out of the window. It's all relative, of course, to what you are doing. In my use, I am usually dragging and dropping a file into the same folder every time for distribution of our app to our analysts. I used to be able to leave that target window very small - 2 or 3 lines - now I can't. One solution would be to allow the user to turn this "feature" off, or reduce the sensitivity somehow. This behavior did just start recently - I have been using FileZilla for years - so something has changed it, if it was not #132. Thanks!

comment:3 by Stephen L'Allier, 8 years ago

Owner: set to Stephen L'Allier
Status: newaccepted

by Stephen L'Allier, 8 years ago

Attachment: drop_target_ex_diff.txt added

comment:4 by Stephen L'Allier, 8 years ago

Type: Bug reportPatch

The unified context diff for the changes we made are attached. It only required a simple change in the drop_target_ex.cpp class.

comment:5 by Stephen L'Allier, 8 years ago

This bug was worked on as a group project at Florida Institute of Technology for an Intro to Software Engineering class. The group members were: Ash Clarke, Stephen L'Allier, Yannis Lewis, and Trung Nguyen. Trung and Stephen primarily worked on this bug.

comment:6 by Tim Kosse, 8 years ago

Unfortunately the patch makes drag-scrolling unbearably slow. It also removes the speedup, if scrolling a large amount of files, scroll speed should gradually increase.

comment:7 by Tim Kosse, 8 years ago

It also removes all usages of the m_count variable, yet does not remove the then unused variable, leaving dead code behind.

comment:8 by Tim Kosse, 8 years ago

Status: acceptedmoreinfo_accepted
Note: See TracTickets for help on using tickets.