Custom Query (8117 matches)

I tried to use Filezilla with a my gss module (​https://sourceforge.net/projects/gssmod/) for proftpd 1.2.8rc2 from cvs and it seems that after the ADAT commands you issue immediatly a CWD command which isn't allowed. Filezilla then tries correctly to use the USER command and proftpd returns a "331 Password required" which can be in case of a successful ADAT a dummy password (The internal structure of proftpd always requires a password, although not necessary). But just here Filezilla closes the connection. I assume it doen't expect a 331 return code.

Markus

Status: Connecting to testserver.test.com ... Trace: ControlSocket.cpp(118): OnAsyncGetHostByName(0, 56, 15) Trace: FtpControlSocket.cpp(652): OnConnect(0) Status: Connected with testserver.test.com. Waiting for welcome message... Trace: FtpControlSocket.cpp(527): OnReceive(0) Response: 220 ProFTPD 1.2.8rc2 Server (ProFTPD Default Installation) [testserver.test.com] Trace: GSSApi.dll: GFtpDoAuth (452, "testserver.test.com", 1738637578, - 828276470, 14025606, 32768, 80, 16841580[0]) Trace: GSSApi.dll: Trying to authenticate to <ftp@…> Trace: GSSApi.dll: Status in line 871: 0, 0 Trace: GSSApi.dll: Status in line 901: 1, 0 Trace: GSSApi.dll: Status in line 901: 0, 0 Trace: GSSApi.dll: GSSAPI authentication succeeded Command: CWD . Trace: FtpControlSocket.cpp(527): OnReceive(0) Response: 530 Please login with USER and PASS Response: ShiW+sP47uBtpcnDilHqC4BNF6FlmUT8yZuxgJWxw8 Qcj6sTqeX6/aY+73060EA1/ifrB5F92zAI+Ubsg== Command: USER testuser Trace: FtpControlSocket.cpp(708): DoClose(4) Trace: FtpControlSocket.cpp(2680): ResetOperation (4100) Error: Unable to connect!

The return value of CAsyncSocketEx::IOCtl() should be inverted. CAsyncSocketEx::IOCtl() calls ioctlsocket() which returns 0 if success, and SOCKET_ERROR if not success.

CAsyncSocketEx::IOCtl() therefore should return TRUE if ioctlsocket() returns 0. This is not the case at the moment. This causes problems in WindowProc() of AsyncSocketEx.cpp when processing the FD_READ event.

A correct implementation of IOCtl() would be:

BOOL CAsyncSocketEx::IOCtl( long lCommand, DWORD* lpArgument ) {

return (SOCKET_ERROR != ioctlsocket

(m_SocketData.hSocket, lCommand, lpArgument)); }

in case numsent < numread, the remainder of the buffer is copied to the beginning of the buffer. However, the code as it is, will miss one byte, due to the incorrect +1. This causes corrupt files on the receiving client. Isn't it possible to use memcpy? or is this a problem as the two ranges overlap?

else if (numsent<numread) { This should not happen, but handle it in case it happens

why shouldn't this happen? send() is not garantueed

to send the specified

number of bytes, so this might very well happen, as

it most certainly

does on the XBOX for (int i=0;i<(numread-numsent);i++) {

m_pBuffer[i]=m_pBuffer[i+numsent+1]; m_pBuffer[i]=m_pBuffer[i+numsent];

}

m_nBufferPos=numread-numsent;

}