Custom Query (8170 matches)

With cppunit 1.14, make check fails with:

make[2]: Entering directory '/home/yen/Projects/tmp/libfilezilla-svn/tests'
/bin/sh ../libtool  --tag=CXX   --mode=link g++  -g -O2 -Wall  -no-install  -o test test-test.o test-dispatch.o test-eventloop.o test-format.o test-iputils.o test-smart_pointer.o test-string.o test-time.o ../lib/libfilezilla.la  -lpthread 
libtool: link: g++ -g -O2 -Wall -o test test-test.o test-dispatch.o test-eventloop.o test-format.o test-iputils.o test-smart_pointer.o test-string.o test-time.o  ../lib/.libs/libfilezilla.so -lpthread -Wl,-rpath -Wl,/home/yen/Projects/tmp/libfilezilla-svn/lib/.libs
test-string.o: In function `string_test::test_conversion()':
/home/yen/Projects/tmp/libfilezilla-svn/tests/string.cpp:40: undefined reference to `CppUnit::SourceLine::SourceLine(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int)'
(and much more "undefined reference" errors)
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:617: test] Error 1
make[2]: Leaving directory '/home/yen/Projects/tmp/libfilezilla-svn/tests'
make[1]: *** [Makefile:1019: check-am] Error 2
make[1]: Leaving directory '/home/yen/Projects/tmp/libfilezilla-svn/tests'
make: *** [Makefile:457: check-recursive] Error 1

The compilation command is missing -lcppunit. A deeper looking into libfilezilla reveals that the latest cppunit breaks it. In m4/cppunit.m4, cppunit-config binary is used to determine compiling and linking flags. However, cppunit-config is dropped upstream in favor of pkg-config. [1] As a result, cppunit detection fails silently and compilation of test programs doesn't work.

A workaround is specifying the necessary flag manually:

LDFLAGS="-lcppunit" ./configure

Note that cppunit 1.14 is libreoffice's fork. According to Wikipedia, [2] the version is used by Debian, Ubuntu, Gentoo and Arch. I believe the issue will affect other distros sooner or later.

[1] ​https://cgit.freedesktop.org/libreoffice/cppunit/commit/?id=c81afa737307ef525258cfae24eb3f2845ce7208 [2] ​https://en.wikipedia.org/wiki/CppUnit#cite_ref-6

For example, on El Capitan, building FileZilla 3.28.0 via MacPorts failed:

/opt/local/bin/clang-mp-4.0 -DHAVE_CONFIG_H -I. -I../../src/include  -I./../include   -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/wx/include/osx_cocoa-unicode-3.0 -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__   -I/opt/local/include -fpch-preprocess  -pipe -Os -arch x86_64 -MT filezilla-power_management_osx.o -MD -MP -MF .deps/filezilla-power_management_osx.Tpo -c -o filezilla-power_management_osx.o `test -f 'power_management_osx.m' || echo './'`power_management_osx.m
file_utils_osx.m:11:22: error: property 'path' cannot be found in forward class object 'NSURL'
                        path = strdup(url.path.UTF8String);
                                      ~~~ ^
/System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:251:8: note: forward declaration of class here
@class NSURL;
       ^
1 error generated.

The full build log can be found at ​https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/40551/steps/install-port/logs/stdio

Need to backport ​https://svn.filezilla-project.org/filezilla?view=revision&revision=8942 for libfilezilla

g++ -DHAVE_CONFIG_H -I. -I../../src/include  -I./../include   -I/usr/lib/wx/include/gtk3-unicode-3.0 -I/usr/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__  -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/libffi-3.2.1/include -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/uuid -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -pthread  -D_FORTIFY_SOURCE=2 -fpch-preprocess  -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -Wall -g -MT filezilla-queue.o -MD -MP -MF .deps/filezilla-queue.Tpo -c -o filezilla-queue.o `test -f 'queue.cpp' || echo './'`queue.cpp
queue.cpp: In member function ‘void CFileItem::SetTargetFile(const wxString&)’:
queue.cpp:333:71: error: no matching function for call to ‘to_wstring(const wxString&)’
   m_targetFile = fz::sparse_optional<std::wstring>(fz::to_wstring(file));
                                                                       ^
In file included from /usr/include/libfilezilla/libfilezilla.hpp:7,
                 from ../../src/include/libfilezilla_engine.h:12,
                 from filezilla.h:4:
/usr/include/libfilezilla/string.hpp:145:31: note: candidate: ‘std::__cxx11::wstring fz::to_wstring(const string&)’
 std::wstring FZ_PUBLIC_SYMBOL to_wstring(std::string const& in);
                               ^~~~~~~~~~
/usr/include/libfilezilla/string.hpp:145:31: note:   no known conversion for argument 1 from ‘const wxString’ to ‘const string&’ {aka ‘const std::__cxx11::basic_string<char>&’}
/usr/include/libfilezilla/string.hpp:148:38: note: candidate: ‘std::__cxx11::wstring fz::to_wstring(const wstring&)’
 inline std::wstring FZ_PUBLIC_SYMBOL to_wstring(std::wstring const& in) { return in; }
                                      ^~~~~~~~~~
/usr/include/libfilezilla/string.hpp:148:38: note:   no known conversion for argument 1 from ‘const wxString’ to ‘const wstring&’ {aka ‘const std::__cxx11::basic_string<wchar_t>&’}
/usr/include/libfilezilla/string.hpp:152:98: note: candidate: ‘template<class Arg> typename std::enable_if<std::is_arithmetic<typename std::decay<_Tp>::type>::value, std::__cxx11::basic_string<wchar_t> >::type fz::to_wstring(Arg&&)’
 inline typename std::enable_if<std::is_arithmetic<std::decay_t<Arg>>::value, std::wstring>::type to_wstring(Arg && arg)
                                                                                                  ^~~~~~~~~~
/usr/include/libfilezilla/string.hpp:152:98: note:   template argument deduction/substitution failed:
/usr/include/libfilezilla/string.hpp: In substitution of ‘template<class Arg> typename std::enable_if<std::is_arithmetic<typename std::decay<_Tp>::type>::value, std::__cxx11::basic_string<wchar_t> >::type fz::to_wstring(Arg&&) [with Arg = const wxString&]’:
queue.cpp:333:71:   required from here
/usr/include/libfilezilla/string.hpp:152:98: error: no type named ‘type’ in ‘struct std::enable_if<false, std::__cxx11::basic_string<wchar_t> >’

Tested on Arch Linux x86_64 and MacPorts with macOS Mojave.