Ticket #8141 (closed Patch: fixed)

Opened 22 months ago

Last modified 2 months ago

bag - Hebrew is shown reverse

Reported by: exorel Owned by:
Priority: normal Component: FileZilla Client
Keywords: Hebrew is shown reverse Cc:
Operating system type: Windows Operating system version: windows 7

Description

Hebrew is shown reverse


Hebrew is the opposite of increases in the down line

See photo

Attachments

bag.png Download (141.6 KB) - added by exorel 22 months ago.
bag1.png Download (192.0 KB) - added by exorel 22 months ago.
8141_mirrored_characters.patch Download (0.5 KB) - added by gronsaken 22 months ago.
8141_mirrored_characters.patch

Change History

Changed 22 months ago by exorel

Changed 22 months ago by gronsaken

Can you please elaborate on the expected behaviour.
I can see that numbers are mirrored but is the order correct?
It would help if you could create an example with the same text as in the picture.

Changed 22 months ago by exorel

Changed 22 months ago by exorel

No, the letters not in the correct order, and they are reflected in the addition ..

look bag1.png

Changed 22 months ago by ci-dev

This bug has been reported already in #5621. However, the screenshot here is more detailed, so I marked the other bug as a duplicate. (Another screenshot is present there.)

Changed 22 months ago by ci-dev

  • priority changed from critical to normal

Changed 22 months ago by gronsaken

8141_mirrored_characters.patch

Changed 22 months ago by gronsaken

The problem was due to different layout directions on background drawing DC and the actual DC shown. Perhaps it could be argued that this is something which should be changed within wxWidgets but I have not dug that deep.

Attached is a patch for review.

As a side-note I noticed that wxMemoryDC::IsOk isn't called after object creation.

Changed 22 months ago by codesquid

  • type changed from Bug report to Patch

Changed 18 months ago by codesquid

  • status changed from new to closed
  • resolution set to fixed

Using FileZilla mirrored makes me dizzy. :)

Thanks for the patch, committed.

Note: See TracTickets for help on using tickets.