Opened 16 years ago
Closed 15 years ago
#4265 closed Patch (fixed)
Make big digits format more user friendly.
Reported by: | silamantex | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | FileZilla Server |
Keywords: | output format user friendly big digits gui | Cc: | silamantex@… |
Component version: | Operating system type: | Windows | |
Operating system version: |
Description
Hi,
It is difficult to read some values in FileZilla Server interface. Such received/sent bytes number etc.
I would like to propouse patch. It divide big numbers by groups, with three digits per each. It is much more easy to read.
Thanks!
Attachments (3)
Change History (7)
by , 16 years ago
Attachment: | make numbers user friendly.zip added |
---|
comment:1 by , 16 years ago
Status: | new → moreinfo |
---|
Thanks, some remarks:
- cstringt.h, is that filea vailable on older versions of visual studio? (especially 2003)
- in Unicode build it'll either fail to compile or there will be lots of additional conversions. Use _T()
- Use GetLocaleInfo to get the proper separator character/string for number formatting. For example English locale uses comma and German locale uses dot, not spaces.
comment:2 by , 16 years ago
Cc: | added |
---|---|
Status: | moreinfo → new |
I have no ability to check cstringt.h under VS2003. But I find in Internet that file should exist there.
Unicode and GetLocaleInfo() added. New version of .cpp attached.
comment:3 by , 16 years ago
Actually it is possible to remove "#include <cstringt.h>" from header OutputFormat.h . Because CString definition available through
<stdafx.h> -> <afxwin.h>
comment:4 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thanks for the patch.
I've slightly adjusted it to get rid of expensive MakeReverse.
patch, sources and example