libfilezilla: FTBFS with GCC 13

[Scott Talbert]

libfilezilla doesn't build with GCC 13 due to some missing includes. Patch attached.

[Tim Kosse]

What's the compile error you are getting?

[Scott Talbert]

One example:

In file included from buffer.cpp:1:
libfilezilla/buffer.hpp:107:33: error: 'uint8_t' was not declared in this scope
  107 |         void append(std::vector<uint8_t> const& data);
      |                                 ^~~~~~~
libfilezilla/buffer.hpp:5:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
    4 | #include "libfilezilla.hpp"
  +++ |+#include <cstdint>
    5 | 
libfilezilla/buffer.hpp:107:40: error: template argument 1 is invalid
  107 |         void append(std::vector<uint8_t> const& data);
      |                                        ^
libfilezilla/buffer.hpp:107:40: error: template argument 2 is invalid
libfilezilla/buffer.hpp:120:40: error: 'uint8_t' was not declared in this scope
  120 |         buffer& operator+=(std::vector<uint8_t> const& data) {
      |                                        ^~~~~~~
libfilezilla/buffer.hpp:120:40: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
libfilezilla/buffer.hpp:120:47: error: template argument 1 is invalid
  120 |         buffer& operator+=(std::vector<uint8_t> const& data) {
      |                                               ^
libfilezilla/buffer.hpp:120:47: error: template argument 2 is invalid
buffer.cpp:174:33: error: 'uint8_t' was not declared in this scope
  174 | void buffer::append(std::vector<uint8_t> const& data)
      |                                 ^~~~~~~
buffer.cpp:8:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
    7 | #include <string.h>
  +++ |+#include <cstdint>
    8 | 
buffer.cpp:174:40: error: template argument 1 is invalid
  174 | void buffer::append(std::vector<uint8_t> const& data)
      |                                        ^
buffer.cpp:174:40: error: template argument 2 is invalid
buffer.cpp: In member function 'void fz::buffer::append(const int&)':
buffer.cpp:176:60: error: request for member 'data' in 'data', which is of non-class type 'const int'
  176 |         append(reinterpret_cast<unsigned char const*>(data.data()), data.size());
      |                                                            ^~~~
buffer.cpp:176:74: error: request for member 'size' in 'data', which is of non-class type 'const int'
  176 |         append(reinterpret_cast<unsigned char const*>(data.data()), data.size());
      |                                                                          ^~~~

Full log here:
​https://kojipkgs.fedoraproject.org//work/tasks/6473/96366473/build.log

[Scott Talbert]

And in case you're curious why these compile errors are new:
​https://www.gnu.org/software/gcc/gcc-13/porting_to.html

[Tim Kosse]

A fix has been committed to the repository.